third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp - Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)

Patch Set: Added a layout test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/html/HTMLFieldSetElement.h ('K') | « third_party/WebKit/Source/core/html/HTMLFieldSetElement.h ('k') | third_party/WebKit/Source/core/html/HTMLFormControlElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLOutputElement.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.

6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)	6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 135 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
146 m_associatedElements.append(toHTMLFormControlElement(&element));	146 m_associatedElements.append(toHTMLFormControlElement(&element));

147 }	147 }

148 }	148 }

149	149

150 const FormAssociatedElement::List& HTMLFieldSetElement::associatedElements() con st	150 const FormAssociatedElement::List& HTMLFieldSetElement::associatedElements() con st

151 {	151 {

152 refreshElementsIfNeeded();	152 refreshElementsIfNeeded();

153 return m_associatedElements;	153 return m_associatedElements;

154 }	154 }

155	155

	156 short HTMLFieldSetElement::tabIndex() const

	157 {

	158 return -1;
	tkent 2016/09/01 23:27:24 We should return HTMLElement::tabIndex(). e.g. < We should return HTMLElement::tabIndex(). e.g. <fieldset tabindex=1> should return 1 for tabIndex. lunalu1 2016/09/02 01:07:38 Done. Show quoted text On 2016/09/01 23:27:24, tkent wrote: > We should return HTMLElement::tabIndex(). > e.g. <fieldset tabindex=1> should return 1 for tabIndex. Done.
	159 }

	160

156 } // namespace blink	161 } // namespace blink

OLD	NEW