third_party/WebKit/Source/core/html/HTMLFormControlElement.h - Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.h

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)

Patch Set: Code review update Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.h b/third_party/WebKit/Source/core/html/HTMLFormControlElement.h

index 370e4f2247856801b8d40ffbf8544f2bafa80597..317aeee501a6668a918c9bfaaf328a77cbe670af 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.h

@@ -156,7 +156,7 @@ private:

bool isFormControlElement() const final { return true; }

bool alwaysCreateUserAgentShadowRoot() const override { return true; }

- short tabIndex() const final;

+ short tabIndex() const;

bool isValidElement() override;

bool matchesValidityPseudoClasses() const override;