third_party/WebKit/Source/core/html/HTMLOutputElement.h - Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLOutputElement.h

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)

Patch Set: Added a layout test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLFormControlElement.h ('k') | third_party/WebKit/Source/core/html/HTMLOutputElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLOutputElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2010 Google Inc. All rights reserved.	2 * Copyright (c) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 bool supportLabels() const override { return true; }	67 bool supportLabels() const override { return true; }

68 bool supportsFocus() const override;	68 bool supportsFocus() const override;

69 void childrenChanged(const ChildrenChange&) override;	69 void childrenChanged(const ChildrenChange&) override;

70 void resetImpl() override;	70 void resetImpl() override;

71	71

72 void valueWasSet() final;	72 void valueWasSet() final;

73	73

74 bool m_isDefaultValueMode;	74 bool m_isDefaultValueMode;

75 String m_defaultValue;	75 String m_defaultValue;

76 Member<DOMTokenList> m_tokens;	76 Member<DOMTokenList> m_tokens;

	77

	78 short tabIndex() const final;
	tkent 2016/09/01 23:27:24 Please move it to the private override block above Please move it to the private override block above. e.g. to next to \|supportsFocus()\|. lunalu1 2016/09/02 01:07:39 Done. Show quoted text On 2016/09/01 23:27:24, tkent wrote: > Please move it to the private override block above. e.g. to next to > \|supportsFocus()\|. Done.
77 };	79 };

78	80

79 } // namespace blink	81 } // namespace blink

80	82

81 #endif // HTMLOutputElement_h	83 #endif // HTMLOutputElement_h

OLD	NEW