Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLOutputElement.cpp

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)
Patch Set: Added a layout test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 { 138 {
139 if (m_defaultValue == value) 139 if (m_defaultValue == value)
140 return; 140 return;
141 m_defaultValue = value; 141 m_defaultValue = value;
142 // The spec requires the value attribute set to the default value 142 // The spec requires the value attribute set to the default value
143 // when the element's value mode flag to "default". 143 // when the element's value mode flag to "default".
144 if (m_isDefaultValueMode) 144 if (m_isDefaultValueMode)
145 setTextContent(value); 145 setTextContent(value);
146 } 146 }
147 147
148 short HTMLOutputElement::tabIndex() const
149 {
150 return -1;
tkent 2016/09/01 23:27:24 We should return HTMLElement::tabIndex().
lunalu1 2016/09/02 01:07:38 Done.
151 }
148 152
149 DEFINE_TRACE(HTMLOutputElement) 153 DEFINE_TRACE(HTMLOutputElement)
150 { 154 {
151 visitor->trace(m_tokens); 155 visitor->trace(m_tokens);
152 HTMLFormControlElement::trace(visitor); 156 HTMLFormControlElement::trace(visitor);
153 DOMTokenListObserver::trace(visitor); 157 DOMTokenListObserver::trace(visitor);
154 } 158 }
155 159
156 } // namespace blink 160 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698