third_party/WebKit/Source/core/html/HTMLFieldSetElement.h - Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable…

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)

Patch Set: Code review update Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html ('k') | third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 void disabledAttributeChanged() override;	46 void disabledAttributeChanged() override;

47	47

48 private:	48 private:

49 HTMLFieldSetElement(Document&, HTMLFormElement*);	49 HTMLFieldSetElement(Document&, HTMLFormElement*);

50	50

51 bool isEnumeratable() const override { return true; }	51 bool isEnumeratable() const override { return true; }

52 bool supportsFocus() const override;	52 bool supportsFocus() const override;

53 LayoutObject* createLayoutObject(const ComputedStyle&) override;	53 LayoutObject* createLayoutObject(const ComputedStyle&) override;

54 const AtomicString& formControlType() const override;	54 const AtomicString& formControlType() const override;

55 bool recalcWillValidate() const override { return false; }	55 bool recalcWillValidate() const override { return false; }

	56 short tabIndex() const final;

56 bool matchesValidityPseudoClasses() const final;	57 bool matchesValidityPseudoClasses() const final;

57 bool isValidElement() final;	58 bool isValidElement() final;

58 void childrenChanged(const ChildrenChange&) override;	59 void childrenChanged(const ChildrenChange&) override;

59 bool areAuthorShadowsAllowed() const override { return false; }	60 bool areAuthorShadowsAllowed() const override { return false; }

60 bool isSubmittableElement() override;	61 bool isSubmittableElement() override;

61 bool alwaysCreateUserAgentShadowRoot() const override { return false; }	62 bool alwaysCreateUserAgentShadowRoot() const override { return false; }

62	63

63 static void invalidateDisabledStateUnder(Element&);	64 static void invalidateDisabledStateUnder(Element&);

64 void refreshElementsIfNeeded() const;	65 void refreshElementsIfNeeded() const;

65	66

66 mutable FormAssociatedElement::List m_associatedElements;	67 mutable FormAssociatedElement::List m_associatedElements;

67 // When dom tree is modified, we have to refresh the m_associatedElements ar ray.	68 // When dom tree is modified, we have to refresh the m_associatedElements ar ray.

68 mutable uint64_t m_documentVersion;	69 mutable uint64_t m_documentVersion;

69 };	70 };

70	71

71 } // namespace blink	72 } // namespace blink

72	73

73 #endif // HTMLFieldSetElement_h	74 #endif // HTMLFieldSetElement_h

OLD	NEW