DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age…

DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools agent hosts.

BUG=627517
TBR=this is a mechanical change

Committed: https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609
Cr-Commit-Position: refs/heads/master@{#414768}

[pfeldman, 2016-08-24 16:43:45]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-08-24 17:17:39]

lgtm

https://codereview.chromium.org/2273063002/diff/1/content/public/browser/devt...
File content/public/browser/devtools_agent_host.h (right):

https://codereview.chromium.org/2273063002/diff/1/content/public/browser/devt...
content/public/browser/devtools_agent_host.h:46: using Ptr =
scoped_refptr<DevToolsAgentHost>;
Unused?

[pfeldman, 2016-08-25 00:16:43]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-08-25 00:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2273063002/#ps20001
(title: "review comment addressed.")

[pfeldman, 2016-08-25 00:17:50]

Description was changed from

==========
DevTools: remove DevToolsTargetDescriptor and its implementations, we are now
based on devtools agent hosts.

BUG=627517
==========

to

==========
DevTools: remove DevToolsTargetDescriptor and its implementations, we are now
based on devtools agent hosts.

BUG=627517
TBR=this is a mechanical change
==========

[commit-bot: I haz the power, 2016-08-25 00:18:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 01:39:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 01:39:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pfeldman, 2016-08-26 17:43:02]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-08-26 17:43:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2273063002/#ps40001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-08-26 17:43:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-08-26 17:54:22]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-08-26 18:07:29]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:08:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:56:11]

Description was changed from

==========
DevTools: remove DevToolsTargetDescriptor and its implementations, we are now
based on devtools agent hosts.

BUG=627517
TBR=this is a mechanical change
==========

to

==========
DevTools: remove DevToolsTargetDescriptor and its implementations, we are now
based on devtools agent hosts.

BUG=627517
TBR=this is a mechanical change
==========

[commit-bot: I haz the power, 2016-08-26 18:56:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-26 19:16:35]

Description was changed from

==========
DevTools: remove DevToolsTargetDescriptor and its implementations, we are now
based on devtools agent hosts.

BUG=627517
TBR=this is a mechanical change
==========

to

==========
DevTools: remove DevToolsTargetDescriptor and its implementations, we are now
based on devtools agent hosts.

BUG=627517
TBR=this is a mechanical change

Committed: https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609
Cr-Commit-Position: refs/heads/master@{#414768}
==========

[commit-bot: I haz the power, 2016-08-26 19:16:36]

Patchset 3 (id:??) landed as
https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609
Cr-Commit-Position: refs/heads/master@{#414768}

[dcheng, 2016-08-26 21:43:44]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-08-26 21:43:44]

https://codereview.chromium.org/2273063002/diff/40001/components/devtools_htt...
File components/devtools_http_handler/devtools_http_handler.cc (right):

https://codereview.chromium.org/2273063002/diff/40001/components/devtools_htt...
components/devtools_http_handler/devtools_http_handler.cc:891:
scoped_refptr<DevToolsAgentHost> agent_host,
Btw, I might be missing something, but I'm a bit confused why this is passed by
scoped_refptr: SerializeDescriptor() doesn't appear to retain a reference to
this or pass it off to anything. So a raw pointer would have been sufficient
(and makes it clear that no ownership is moving)

[pfeldman, 2016-08-26 22:31:32]

https://codereview.chromium.org/2273063002/diff/40001/components/devtools_htt...
File components/devtools_http_handler/devtools_http_handler.cc (right):

https://codereview.chromium.org/2273063002/diff/40001/components/devtools_htt...
components/devtools_http_handler/devtools_http_handler.cc:891:
scoped_refptr<DevToolsAgentHost> agent_host,
Moving ownership is only essential for movable / unique_ptr. I prefer to include
scoped_refptr<> into the signature for all refcounted objects so that it was
clear whether they can be retained.