Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.h

Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_targets_ui.h
diff --git a/chrome/browser/devtools/devtools_targets_ui.h b/chrome/browser/devtools/devtools_targets_ui.h
index 43778a321d6793123b83a1665327a35b8b93be43..cbc45561a65ea3265bbf9feb9ecb5db968ae3145 100644
--- a/chrome/browser/devtools/devtools_targets_ui.h
+++ b/chrome/browser/devtools/devtools_targets_ui.h
@@ -18,7 +18,6 @@ class ListValue;
class DictionaryValue;
}
-class DevToolsTargetImpl;
class Profile;
class DevToolsTargetsUIHandler {
@@ -39,7 +38,8 @@ class DevToolsTargetsUIHandler {
const Callback& callback,
Profile* profile);
- DevToolsTargetImpl* GetTarget(const std::string& target_id);
+ scoped_refptr<content::DevToolsAgentHost> GetTarget(
+ const std::string& target_id);
virtual void Open(const std::string& browser_id, const std::string& url);
@@ -49,10 +49,12 @@ class DevToolsTargetsUIHandler {
virtual void ForceUpdate();
protected:
- base::DictionaryValue* Serialize(const DevToolsTargetImpl& target);
+ base::DictionaryValue* Serialize(
+ scoped_refptr<content::DevToolsAgentHost> host);
void SendSerializedTargets(const base::ListValue& list);
- typedef std::map<std::string, DevToolsTargetImpl*> TargetMap;
+ using TargetMap =
+ std::map<std::string, scoped_refptr<content::DevToolsAgentHost>>;
TargetMap targets_;
private:

Powered by Google App Engine
This is Rietveld 408576698