Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1766)

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
index dd5a92625c61dcb85586b9bcc1f6a18a2a00d3e1..d2c6c570ec9cf23adce6848f1e3e2cace882a566 100644
--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/devtools/device/adb/adb_device_provider.h"
#include "chrome/browser/devtools/device/adb/mock_adb_server.h"
#include "chrome/browser/devtools/device/devtools_android_bridge.h"
-#include "chrome/browser/devtools/devtools_target_impl.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/browser/browser_thread.h"
@@ -108,25 +107,25 @@ class AdbClientSocketTest : public InProcessBrowserTest,
ASSERT_EQ(1U, chrome_beta_pages.size());
ASSERT_EQ(2U, webview_pages.size());
- std::unique_ptr<DevToolsTargetImpl> chrome_target(
+ scoped_refptr<content::DevToolsAgentHost> chrome_target(
android_bridge_->CreatePageTarget(chrome_pages[0]));
- std::unique_ptr<DevToolsTargetImpl> chrome_beta_target(
+ scoped_refptr<content::DevToolsAgentHost> chrome_beta_target(
android_bridge_->CreatePageTarget(chrome_beta_pages[0]));
- std::unique_ptr<DevToolsTargetImpl> webview_target_0(
+ scoped_refptr<content::DevToolsAgentHost> webview_target_0(
android_bridge_->CreatePageTarget(webview_pages[0]));
- std::unique_ptr<DevToolsTargetImpl> webview_target_1(
+ scoped_refptr<content::DevToolsAgentHost> webview_target_1(
android_bridge_->CreatePageTarget(webview_pages[1]));
// Check that we have non-empty description for webview pages.
- ASSERT_EQ(0U, chrome_target->GetAgentHost()->GetDescription().size());
- ASSERT_EQ(0U, chrome_beta_target->GetAgentHost()->GetDescription().size());
- ASSERT_NE(0U, webview_target_0->GetAgentHost()->GetDescription().size());
- ASSERT_NE(0U, webview_target_1->GetAgentHost()->GetDescription().size());
+ ASSERT_EQ(0U, chrome_target->GetDescription().size());
+ ASSERT_EQ(0U, chrome_beta_target->GetDescription().size());
+ ASSERT_NE(0U, webview_target_0->GetDescription().size());
+ ASSERT_NE(0U, webview_target_1->GetDescription().size());
ASSERT_EQ(GURL("http://www.chromium.org/"),
- chrome_target->GetAgentHost()->GetURL());
+ chrome_target->GetURL());
ASSERT_EQ("The Chromium Projects",
- chrome_target->GetAgentHost()->GetTitle());
+ chrome_target->GetTitle());
}
private:

Powered by Google App Engine
This is Rietveld 408576698