Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc
index 6beea1bdd3721d4fab1d601751d250bf5a3f94c3..a64ff5b36bbae2716df31b287e059517c8e3df3d 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc
@@ -27,7 +27,6 @@
#include "base/values.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/devtools/chrome_devtools_manager_delegate.h"
-#include "chrome/browser/devtools/devtools_target_impl.h"
#include "chrome/browser/devtools/global_confirm_info_bar.h"
#include "chrome/browser/extensions/api/debugger/debugger_api_constants.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -678,9 +677,8 @@ const char kTargetTabIdField[] = "tabId";
const char kTargetExtensionIdField[] = "extensionId";
const char kTargetTypeWorker[] = "worker";
-base::Value* SerializeTarget(const DevToolsTargetImpl& target) {
+base::Value* SerializeTarget(scoped_refptr<DevToolsAgentHost> host) {
base::DictionaryValue* dictionary = new base::DictionaryValue();
- scoped_refptr<DevToolsAgentHost> host = target.GetAgentHost();
dictionary->SetString(kTargetIdField, host->GetId());
dictionary->SetString(kTargetTitleField, host->GetTitle());
dictionary->SetBoolean(kTargetAttachedField, host->IsAttached());
@@ -718,7 +716,7 @@ DebuggerGetTargetsFunction::~DebuggerGetTargetsFunction() {
}
bool DebuggerGetTargetsFunction::RunAsync() {
- std::vector<DevToolsTargetImpl*> list = DevToolsTargetImpl::EnumerateAll();
+ content::DevToolsAgentHost::List list = DevToolsAgentHost::GetOrCreateAll();
content::BrowserThread::PostTask(
content::BrowserThread::UI,
FROM_HERE,
@@ -727,11 +725,10 @@ bool DebuggerGetTargetsFunction::RunAsync() {
}
void DebuggerGetTargetsFunction::SendTargetList(
- const std::vector<DevToolsTargetImpl*>& target_list) {
+ const content::DevToolsAgentHost::List& target_list) {
std::unique_ptr<base::ListValue> result(new base::ListValue());
for (size_t i = 0; i < target_list.size(); ++i)
- result->Append(SerializeTarget(*target_list[i]));
- base::STLDeleteContainerPointers(target_list.begin(), target_list.end());
+ result->Append(SerializeTarget(target_list[i]));
SetResult(std::move(result));
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698