chrome/browser/ui/webui/inspect_ui.cc - Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/inspect_ui.cc

diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc

index 4cbeda3061a648c43e559dc339e0ab3b01fc7770..4c82722ea407c74a48ce8d1f36d4591d54dabc39 100644

--- a/chrome/browser/ui/webui/inspect_ui.cc

+++ b/chrome/browser/ui/webui/inspect_ui.cc

@@ -6,7 +6,6 @@

#include "base/macros.h"

#include "base/stl_util.h"

-#include "chrome/browser/devtools/devtools_target_impl.h"

#include "chrome/browser/devtools/devtools_targets_ui.h"

#include "chrome/browser/devtools/devtools_ui_bindings.h"

#include "chrome/browser/profiles/profile.h"

@@ -505,9 +504,8 @@ DevToolsTargetsUIHandler* InspectUI::FindTargetHandler(

scoped_refptr<content::DevToolsAgentHost> InspectUI::FindTarget(

const std::string& source_id, const std::string& target_id) {

TargetHandlerMap::iterator it = target_handlers_.find(source_id);

- DevToolsTargetImpl* target = it != target_handlers_.end() ?

+ return it != target_handlers_.end() ?

it->second->GetTarget(target_id) : nullptr;

- return target ? target->GetAgentHost() : nullptr;

}

void InspectUI::PopulateTargets(const std::string& source,

« no previous file with comments | « chrome/browser/ui/webui/inspect_ui.h ('k') | chrome/chrome_debugger.gypi » ('j') | components/devtools_http_handler/devtools_http_handler.cc » ('J')