Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.cc

Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/devtools_android_bridge.cc
diff --git a/chrome/browser/devtools/device/devtools_android_bridge.cc b/chrome/browser/devtools/device/devtools_android_bridge.cc
index fd9e51e5363c9de9e190d62bde4d195cce2befe2..606e540bb38c0e8dc878bda42e74b3dae7742919 100644
--- a/chrome/browser/devtools/device/devtools_android_bridge.cc
+++ b/chrome/browser/devtools/device/devtools_android_bridge.cc
@@ -32,7 +32,6 @@
#include "chrome/browser/devtools/device/tcp_device_provider.h"
#include "chrome/browser/devtools/device/usb/usb_device_provider.h"
#include "chrome/browser/devtools/devtools_protocol.h"
-#include "chrome/browser/devtools/devtools_target_impl.h"
#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/devtools/remote_debugging_server.h"
#include "chrome/browser/profiles/profile.h"
@@ -602,17 +601,14 @@ DevToolsAndroidBridge::RemoteBrowser::GetParsedVersion() {
return result;
}
-DevToolsTargetImpl*
+scoped_refptr<content::DevToolsAgentHost>
DevToolsAndroidBridge::CreatePageTarget(scoped_refptr<RemotePage> page) {
std::string local_id = BuildUniqueTargetId(page->browser_id_,
page->dict_.get());
std::string target_path = GetTargetPath(page->dict_.get());
std::string type = GetStringProperty(page->dict_.get(), "type");
- scoped_refptr<DevToolsAgentHost> host =
- AgentHostDelegate::GetOrCreateAgentHost(this, page->browser_id_, local_id,
- target_path, type,
- page->dict_.get());
- return new DevToolsTargetImpl(host);
+ return AgentHostDelegate::GetOrCreateAgentHost(
+ this, page->browser_id_, local_id, target_path, type, page->dict_.get());
}
void DevToolsAndroidBridge::SendJsonRequest(

Powered by Google App Engine
This is Rietveld 408576698