chrome/browser/devtools/device/devtools_android_bridge.h - Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.h

Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc ('k') | chrome/browser/devtools/device/devtools_android_bridge.cc » ('j') | components/devtools_http_handler/devtools_http_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/devtools_android_bridge.h

diff --git a/chrome/browser/devtools/device/devtools_android_bridge.h b/chrome/browser/devtools/device/devtools_android_bridge.h

index 73f4c62b93a31b5f752a7404752c5daedab68de2..374dd1d0b84b9628af6ae469619ed93a1f953954 100644

--- a/chrome/browser/devtools/device/devtools_android_bridge.h

+++ b/chrome/browser/devtools/device/devtools_android_bridge.h

@@ -34,7 +34,6 @@ namespace content {

class BrowserContext;

}

-class DevToolsTargetImpl;

class PortForwardingController;

class Profile;

class TCPDeviceProvider;

@@ -204,7 +203,8 @@ class DevToolsAndroidBridge : public KeyedService {

bool HasDevToolsWindow(const std::string& agent_id);

// Creates new target instance owned by caller.

- DevToolsTargetImpl* CreatePageTarget(scoped_refptr<RemotePage> browser);

+ scoped_refptr<content::DevToolsAgentHost>

+ CreatePageTarget(scoped_refptr<RemotePage> browser);

using RemotePageCallback = base::Callback<void(scoped_refptr<RemotePage>)>;

void OpenRemotePage(scoped_refptr<RemoteBrowser> browser,