Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2273063002: DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools age… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 8fff9900c07e688cf73b24188857258a91b7d116..6626adb7975cd2a7f6ea304a6a48ce601856c850 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -23,7 +23,6 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/devtools/devtools_file_watcher.h"
#include "chrome/browser/devtools/devtools_protocol.h"
-#include "chrome/browser/devtools/devtools_target_impl.h"
#include "chrome/browser/devtools/global_confirm_info_bar.h"
#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
#include "chrome/browser/infobars/infobar_service.h"
@@ -758,17 +757,18 @@ void DevToolsUIBindings::PerformActionOnRemotePage(const std::string& page_id,
const std::string& action) {
if (!remote_targets_handler_)
return;
- DevToolsTargetImpl* target = remote_targets_handler_->GetTarget(page_id);
- if (!target)
+ scoped_refptr<content::DevToolsAgentHost> host =
+ remote_targets_handler_->GetTarget(page_id);
+ if (!host)
return;
if (action == kRemotePageActionInspect)
- target->GetAgentHost()->Inspect();
+ host->Inspect();
if (action == kRemotePageActionReload)
- target->GetAgentHost()->Reload();
+ host->Reload();
if (action == kRemotePageActionActivate)
- target->GetAgentHost()->Activate();
+ host->Activate();
if (action == kRemotePageActionClose)
- target->GetAgentHost()->Close();
+ host->Close();
}
void DevToolsUIBindings::OpenRemotePage(const std::string& browser_id,

Powered by Google App Engine
This is Rietveld 408576698