Adds ImmersiveContext and ImmersiveHandlerFactory

Adds ImmersiveContext and ImmersiveHandlerFactory

The immersive code needs to support running in ash, mash, chrome in
ash and chrome in mash, all of which have slightly different
requirements. ImmersiveContext and ImmersiveHandlerFactory provide the
basis for this. ImmersiveContext provides the interactions with the
shell/window types and ImmersiveHandlerFactory the factory for
creating the event watchers.

My plan is to move ImmersiveFullscreenController into ash/shared
shortly (along with a couple of other classes).

BUG=627146
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/b7b5409a74efc0a764a4ddd2010d0db4309713b0
Cr-Commit-Position: refs/heads/master@{#413155}

[sky, 2016-08-18 18:22:14]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:22:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:33:55]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[sky, 2016-08-18 19:05:36]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 19:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 19:55:52]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-19 00:37:14]

https://codereview.chromium.org/2260613002/diff/40001/ash/shared/immersive_co...
File ash/shared/immersive_context.h (right):

https://codereview.chromium.org/2260613002/diff/40001/ash/shared/immersive_co...
ash/shared/immersive_context.h:29: // ImmersiveContext is a singleton.
nice docs

https://codereview.chromium.org/2260613002/diff/40001/ash/shared/immersive_co...
ash/shared/immersive_context.h:46: // Returns the bounds of the display the
widget is on, in screen coordiantes.
nit: coordinates

https://codereview.chromium.org/2260613002/diff/40001/ash/shared/immersive_co...
ash/shared/immersive_context.h:49: virtual void
AddPointerWatcher(views::PointerWatcher* watcher,
nit: "// See WmShell::AddPointerWatcher for details", since that contains the
warning against using wants_moves

https://codereview.chromium.org/2260613002/diff/40001/ash/wm/immersive_fullsc...
File ash/wm/immersive_fullscreen_controller.cc (right):

https://codereview.chromium.org/2260613002/diff/40001/ash/wm/immersive_fullsc...
ash/wm/immersive_fullscreen_controller.cc:125: if (immersive_focus_watcher_)
It looks like your implementation of CreateFocusWatcher always returns a
watcher. Do you need these if()s?

[sky, 2016-08-19 03:30:47]

https://codereview.chromium.org/2260613002/diff/40001/ash/shared/immersive_co...
File ash/shared/immersive_context.h (right):

https://codereview.chromium.org/2260613002/diff/40001/ash/shared/immersive_co...
ash/shared/immersive_context.h:46: // Returns the bounds of the display the
widget is on, in screen coordiantes.
On 2016/08/19 00:37:14, James Cook (slow reviews) wrote:
> nit: coordinates

My vision is SO GOING DOWNHILL!

https://codereview.chromium.org/2260613002/diff/40001/ash/shared/immersive_co...
ash/shared/immersive_context.h:49: virtual void
AddPointerWatcher(views::PointerWatcher* watcher,
On 2016/08/19 00:37:14, James Cook (slow reviews) wrote:
> nit: "// See WmShell::AddPointerWatcher for details", since that contains the
> warning against using wants_moves
> 

Done.

https://codereview.chromium.org/2260613002/diff/40001/ash/wm/immersive_fullsc...
File ash/wm/immersive_fullscreen_controller.cc (right):

https://codereview.chromium.org/2260613002/diff/40001/ash/wm/immersive_fullsc...
ash/wm/immersive_fullscreen_controller.cc:125: if (immersive_focus_watcher_)
On 2016/08/19 00:37:14, James Cook (slow reviews) wrote:
> It looks like your implementation of CreateFocusWatcher always returns a
> watcher. Do you need these if()s?

The mash implementation will return null initially, and may return null always,
I have to poke at it some more.

[sky, 2016-08-19 03:31:04]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 03:31:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 04:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 04:28:18]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-19 15:49:59]

LGTM

https://codereview.chromium.org/2260613002/diff/40001/ash/wm/immersive_fullsc...
File ash/wm/immersive_fullscreen_controller.cc (right):

https://codereview.chromium.org/2260613002/diff/40001/ash/wm/immersive_fullsc...
ash/wm/immersive_fullscreen_controller.cc:125: if (immersive_focus_watcher_)
On 2016/08/19 03:30:47, sky wrote:
> On 2016/08/19 00:37:14, James Cook (slow reviews) wrote:
> > It looks like your implementation of CreateFocusWatcher always returns a
> > watcher. Do you need these if()s?
> 
> The mash implementation will return null initially, and may return null
always,
> I have to poke at it some more.

OK. If you end up with a mash implementation that always returns a non-null one,
please clean up these if()s, as it makes it harder for me to reason about when
the lock exists.

[sky, 2016-08-19 15:56:12]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-19 15:56:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 16:00:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-19 16:03:38]

Description was changed from

==========
Adds ImmersiveContext and ImmersiveHandlerFactory

The immersive code needs to support running in ash, mash, chrome in
ash and chrome in mash, all of which have slightly different
requirements. ImmersiveContext and ImmersiveHandlerFactory provide the
basis for this. ImmersiveContext provides the interactions with the
shell/window types and ImmersiveHandlerFactory the factory for
creating the event watchers.

My plan is to move ImmersiveFullscreenController into ash/shared
shortly (along with a couple of other classes).

BUG=627146
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Adds ImmersiveContext and ImmersiveHandlerFactory

The immersive code needs to support running in ash, mash, chrome in
ash and chrome in mash, all of which have slightly different
requirements. ImmersiveContext and ImmersiveHandlerFactory provide the
basis for this. ImmersiveContext provides the interactions with the
shell/window types and ImmersiveHandlerFactory the factory for
creating the event watchers.

My plan is to move ImmersiveFullscreenController into ash/shared
shortly (along with a couple of other classes).

BUG=627146
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/b7b5409a74efc0a764a4ddd2010d0db4309713b0
Cr-Commit-Position: refs/heads/master@{#413155}
==========

[commit-bot: I haz the power, 2016-08-19 16:03:38]

Patchset 5 (id:??) landed as
https://crrev.com/b7b5409a74efc0a764a4ddd2010d0db4309713b0
Cr-Commit-Position: refs/heads/master@{#413155}