Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Every time PasswordFormManager is constructed in production code,
FetchDataFromPasswordStore is called on it immediately after construction.
It makes sense to automate calling FetchDataFromPasswordStore.

Doing so will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller. (See the overall plan
in https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#bookmark=id.cbgso0v3oogv

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
R=vasilii@chromium.org

Committed: https://crrev.com/68d599d1defb2c1369cbcaa398b7164a40a41f02
Cr-Commit-Position: refs/heads/master@{#412773}

[vabr (Chromium), 2016-08-17 14:41:38]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 14:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 14:58:40]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vabr (Chromium), 2016-08-17 15:08:53]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:09:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-17 15:12:40]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:13:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:32:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-08-18 07:55:56]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 07:56:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-18 08:27:28]

Description was changed from

==========
Call PasswordFormManager::FetchDataFromPasswordStore in constructor

This method has always been called right after construction, it makes sense to
automate it. It will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller.

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
==========

to

==========
Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Every time PasswordFormManager is constructed in production code,
FetchDataFromPasswordStore is called on it immediately after construction.
It makes sense to automate calling FetchDataFromPasswordStore.

Doing so will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller. (See the overall plan
in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
R=vasilii@chromium.org
==========

[vabr (Chromium), 2016-08-18 08:27:28]

vabr@chromium.org changed reviewers:
+ vasilii@chromium.org

[vabr (Chromium), 2016-08-18 08:27:45]

Hi Vasilii,

PTAL.

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-08-18 08:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:38:21]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-08-18 08:56:39]

lgtm

[vabr (Chromium), 2016-08-18 08:57:57]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:58:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 09:19:18]

Description was changed from

==========
Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Every time PasswordFormManager is constructed in production code,
FetchDataFromPasswordStore is called on it immediately after construction.
It makes sense to automate calling FetchDataFromPasswordStore.

Doing so will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller. (See the overall plan
in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
R=vasilii@chromium.org
==========

to

==========
Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Every time PasswordFormManager is constructed in production code,
FetchDataFromPasswordStore is called on it immediately after construction.
It makes sense to automate calling FetchDataFromPasswordStore.

Doing so will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller. (See the overall plan
in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
R=vasilii@chromium.org
==========

[commit-bot: I haz the power, 2016-08-18 09:19:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-18 09:22:03]

Description was changed from

==========
Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Every time PasswordFormManager is constructed in production code,
FetchDataFromPasswordStore is called on it immediately after construction.
It makes sense to automate calling FetchDataFromPasswordStore.

Doing so will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller. (See the overall plan
in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
R=vasilii@chromium.org
==========

to

==========
Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Every time PasswordFormManager is constructed in production code,
FetchDataFromPasswordStore is called on it immediately after construction.
It makes sense to automate calling FetchDataFromPasswordStore.

Doing so will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller. (See the overall plan
in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
R=vasilii@chromium.org

Committed: https://crrev.com/68d599d1defb2c1369cbcaa398b7164a40a41f02
Cr-Commit-Position: refs/heads/master@{#412773}
==========

[commit-bot: I haz the power, 2016-08-18 09:22:06]

Patchset 5 (id:??) landed as
https://crrev.com/68d599d1defb2c1369cbcaa398b7164a40a41f02
Cr-Commit-Position: refs/heads/master@{#412773}