components/password_manager/core/browser/password_form_manager.cc - Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_FormDigest_prettyprint

Patch Set: Fixed interactive_ui_tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager.h ('k') | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index 0cfc92cfcb50980c63aa3cd9f8086340fb504f7a..cef9cba66e2ded977d9c6dc0eabb2d0a333250c2 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -214,6 +214,7 @@ PasswordFormManager::PasswordFormManager(

driver != nullptr);

if (driver)

drivers_.push_back(driver);

+ FetchDataFromPasswordStore();

}

PasswordFormManager::~PasswordFormManager() {

@@ -430,7 +431,9 @@ void PasswordFormManager::FetchDataFromPasswordStore() {

if (!password_store) {

if (logger)

logger->LogMessage(Logger::STRING_NO_STORE);

- NOTREACHED();

+ // TODO(crbug.com/621355): The store might be empty in some tests. Start

+ // enforcing the presence of a (non-null) PasswordStore once FormFetcher is

+ // fetching the credentials instead of PasswordFormManager.

return;

}

password_store->GetLogins(PasswordStore::FormDigest(observed_form_), this);