components/password_manager/sync/browser/sync_credentials_filter_unittest.cc - Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_FormDigest_prettyprint

Patch Set: Fixed interactive_ui_tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

diff --git a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

index 5f26c17d5a58eef0be5d8a977e0e68dffff4c6dd..e5879ee11f7aba963a38ae4fe6faf4118eed4b36 100644

--- a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

+++ b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

@@ -128,7 +128,6 @@ class CredentialsFilterTest : public SyncUsernameTestBase {

&password_manager_, &client_, driver_.AsWeakPtr(), pending,

base::WrapUnique(new StubFormSaver)));

- form_manager->FetchDataFromPasswordStore();

ScopedVector<PasswordForm> saved_forms;

if (login_state == LoginState::EXISTING) {

saved_forms.push_back(new PasswordForm(pending));

« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | no next file » | no next file with comments »