Simplify PasswordFormManagerState

Simplify PasswordFormManagerState

PasswordFormManagerState has 3 states: pre-matching, matching and post-matching
phase. After https://codereview.chromium.org/2256703002, none of its public
methods can be called during the pre-matching phase.

Therefore only the matching and post-matching phase values are needed. This CL:
* Removes the "pre-matching phase" value
* Renames the remaining values to better describe what they mean
* Removes duplicity from the enum name, makes it an enum class and fixes its
  position in the class declaration

R=dvadym@chromium.org
BUG=621355
Committed: https://crrev.com/10eebf2b1a61983cd3e0ae67eb5d77b1dd3bb945
Cr-Commit-Position: refs/heads/master@{#412792}

[vabr (Chromium), 2016-08-17 14:56:51]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:57:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:10:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:10:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-08-17 15:13:29]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:13:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:47:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-08-18 08:28:40]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 08:28:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-18 08:58:37]

Hi Vadym,

Could you please review this change?

Thanks!
Vaclav

[dvadym, 2016-08-18 09:06:50]

LGTM

https://codereview.chromium.org/2250133003/diff/50001/components/password_man...
File components/password_manager/core/browser/password_form_manager.h (right):

https://codereview.chromium.org/2250133003/diff/50001/components/password_man...
components/password_manager/core/browser/password_form_manager.h:328: enum class
State { NOT_WAITING, WAITING };
Oh, good to know, I didn't know that it's already allowed to use scoped enums.

[vabr (Chromium), 2016-08-18 09:27:24]

Thanks!

https://codereview.chromium.org/2250133003/diff/50001/components/password_man...
File components/password_manager/core/browser/password_form_manager.h (right):

https://codereview.chromium.org/2250133003/diff/50001/components/password_man...
components/password_manager/core/browser/password_form_manager.h:328: enum class
State { NOT_WAITING, WAITING };
On 2016/08/18 09:06:50, dvadym wrote:
> Oh, good to know, I didn't know that it's already allowed to use scoped enums.

Yes, https://chromium-cpp.appspot.com/ has been allowing them for some time now.

On many places, non-class enums are still a good option, especially when
implicit casting to integers is welcome. Here, however, the namespace scoping
here is helpful, and implicit casting is not needed, so I changed to enum class.

[vabr (Chromium), 2016-08-18 09:31:00]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2016-08-18 09:31:01]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-08-18 09:31:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 10:47:22]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-08-18 10:51:06]

Description was changed from

==========
Simplify PasswordFormManagerState

PasswordFormManagerState has 3 states: pre-matching, matching and post-matching
phase. After https://codereview.chromium.org/2256703002, none of its public
methods can be called during the pre-matching phase.

Therefore only the matching and post-matching phase values are needed. This CL:
* Removes the "pre-matching phase" value
* Renames the remaining values to better describe what they mean
* Removes duplicity from the enum name, makes it an enum class and fixes its
  position in the class declaration

R=dvadym@chromium.org
BUG=621355
==========

to

==========
Simplify PasswordFormManagerState

PasswordFormManagerState has 3 states: pre-matching, matching and post-matching
phase. After https://codereview.chromium.org/2256703002, none of its public
methods can be called during the pre-matching phase.

Therefore only the matching and post-matching phase values are needed. This CL:
* Removes the "pre-matching phase" value
* Renames the remaining values to better describe what they mean
* Removes duplicity from the enum name, makes it an enum class and fixes its
  position in the class declaration

R=dvadym@chromium.org
BUG=621355

Committed: https://crrev.com/10eebf2b1a61983cd3e0ae67eb5d77b1dd3bb945
Cr-Commit-Position: refs/heads/master@{#412792}
==========

[commit-bot: I haz the power, 2016-08-18 10:51:07]

Patchset 4 (id:??) landed as
https://crrev.com/10eebf2b1a61983cd3e0ae67eb5d77b1dd3bb945
Cr-Commit-Position: refs/heads/master@{#412792}