chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc - Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_FormDigest_prettyprint

Patch Set: Fixed interactive_ui_tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.cc ('k') | components/password_manager/core/browser/credential_manager_password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

index a8a3037a9790b4fb87c530bb5d85528594ef1ff9..97025e8f84fd8c94675731b8f761bd02e61ada5b 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

@@ -240,7 +240,6 @@ ManagePasswordsUIControllerTest::CreateFormManagerWithBestMatches(

new password_manager::PasswordFormManager(

&password_manager_, &client_, driver_.AsWeakPtr(), observed_form,

base::WrapUnique(new password_manager::StubFormSaver)));

- test_form_manager->SimulateFetchMatchingLoginsFromPasswordStore();

test_form_manager->OnGetPasswordStoreResults(std::move(best_matches));

return test_form_manager;

}