components/password_manager/core/browser/credential_manager_password_form_manager.cc - Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_password_form_manager.cc

Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_FormDigest_prettyprint

Patch Set: Fixed interactive_ui_tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_password_form_manager.cc

diff --git a/components/password_manager/core/browser/credential_manager_password_form_manager.cc b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

index 91bdbdc2e31d17d40bbb924cfdeab66fc2efcb26..119ceb9a9d585abbc3c389e3ead742a822cb4fac 100644

--- a/components/password_manager/core/browser/credential_manager_password_form_manager.cc

+++ b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

@@ -32,7 +32,6 @@ CredentialManagerPasswordFormManager::CredentialManagerPasswordFormManager(

delegate_(delegate),

saved_form_(std::move(saved_form)) {

DCHECK(saved_form_);

- FetchDataFromPasswordStore();

}

CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {