Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_FormDigest_prettyprint
Patch Set: Fixed interactive_ui_tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index dcf317d68a9ebaad3dbcf88ae32a12673e4bca1c..f201bf91ca9af38325e050c913b1f8c24fdc5774 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -77,7 +77,9 @@ class PasswordFormManager : public PasswordStoreConsumer {
MatchResultMask DoesManage(const autofill::PasswordForm& form) const;
// Retrieves potential matching logins from the database. In addition the
- // statistics is retrived on platforms with the password bubble.
+ // statistics is retrived on platforms with the password bubble. This is
+ // called automatically during construction and can be called manually later
+ // as well to cause an update of the cached credentials.
void FetchDataFromPasswordStore();
// Simple state-check to verify whether this object as received a callback
@@ -224,13 +226,6 @@ class PasswordFormManager : public PasswordStoreConsumer {
return blacklisted_matches_;
}
-#if defined(UNIT_TEST)
- void SimulateFetchMatchingLoginsFromPasswordStore() {
- // Just need to update the internal states.
- state_ = MATCHING_PHASE;
- }
-#endif
-
const std::vector<std::unique_ptr<InteractionsStats>>& interactions_stats()
const {
return interactions_stats_;

Powered by Google App Engine
This is Rietveld 408576698