Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2256703002: Call PasswordFormManager::FetchDataFromPasswordStore in constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_FormDigest_prettyprint
Patch Set: Fixed interactive_ui_tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/sync/browser/sync_credentials_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index e3cc09f68f0077f5af21ef3b9482197cb8b6c87d..6a9c10ff37dfa9c79f6eb3177a9527fc7e5e911c 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -232,7 +232,6 @@ void PasswordManager::SetGenerationElementAndReasonForForm(
auto manager = base::WrapUnique(new PasswordFormManager(
this, client_, driver->AsWeakPtr(), form,
base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore()))));
- manager->FetchDataFromPasswordStore();
pending_login_managers_.push_back(std::move(manager));
}
@@ -525,7 +524,6 @@ void PasswordManager::CreatePendingLoginManagers(
(driver ? driver->AsWeakPtr() : base::WeakPtr<PasswordManagerDriver>()),
*iter,
base::WrapUnique(new FormSaverImpl(client_->GetPasswordStore()))));
- manager->FetchDataFromPasswordStore();
pending_login_managers_.push_back(std::move(manager));
}
« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/sync/browser/sync_credentials_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698