Instrument parser blocking script execution time.

Instrument parser blocking script execution time.

We already track parser blocking script load time. This patch
adds support for tracking parser blocking script execution time.

We have a few use cases for this:
* allows us to understand % of parse time blocked on script exec
  time, to better understand whether script exec time is a
  significant contributor to page load time
* having this would have helped us to catch a regression that took
  hours of time to identify the root cause of (crbug.com/608424)
* there is a desire to understand how much time scripts inserted
  via doc.write spend executing, in addition to loading

BUG=640260
Committed: https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473
Cr-Commit-Position: refs/heads/master@{#417330}

[Bryan McQuade, 2016-08-10 17:23:00]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 17:23:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-08-10 17:29:11]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 17:30:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:49:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bryan McQuade, 2016-08-10 22:32:19]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 22:34:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 22:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:39:14]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Bryan McQuade, 2016-08-10 23:26:41]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 23:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:34:08]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Bryan McQuade, 2016-08-11 10:57:41]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 10:57:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 12:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 12:39:35]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-08-14 17:57:38]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 17:57:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-08-14 18:41:37]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 18:41:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-08-14 18:44:16]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 18:44:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-14 20:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-14 20:01:29]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-08-23 17:53:23]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 17:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-08-23 17:57:01]

Description was changed from

==========
Instrument parser blocking script execution time.

BUG=
==========

to

==========
Instrument parser blocking script execution time.

BUG=640260
==========

[Bryan McQuade, 2016-08-23 17:58:24]

Description was changed from

==========
Instrument parser blocking script execution time.

BUG=640260
==========

to

==========
Instrument parser blocking script execution time.

We already track parser blocking script load time. This patch
adds support for tracking parser blocking script execution time.

We have a few use cases for this:
* allows us to understand % of parse time blocked on script exec
  time, to better understand whether script exec time is a
  significant contributor to page load time
* having this would have helped us to catch a regression that took
  hours of time to identify the root cause of (crbug.com/608424)
* there is a desire to understand how much time scripts inserted
  via doc.write spend executing, in addition to loading

BUG=640260
==========

[commit-bot: I haz the power, 2016-08-23 19:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:53:57]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-08-23 21:34:10]

bmcquade@chromium.org changed reviewers:
+ japhet@chromium.org, kouhei@chromium.org

[Bryan McQuade, 2016-08-23 21:35:04]

kouhei and japhet, PTAL for third_party/WebKit.

[kouhei (in TOK), 2016-08-26 10:01:48]

https://codereview.chromium.org/2238543002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/ScriptLoader.h (right):

https://codereview.chromium.org/2238543002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/ScriptLoader.h:129:
WTF::Optional<ScriptRunner::ExecutionType> m_asyncExecType;
Would you add another ExecutionType instead of WTF::Optional?

[Bryan McQuade, 2016-08-28 20:06:03]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-28 20:06:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-28 20:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-28 20:17:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bryan McQuade, 2016-08-28 20:34:28]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-28 20:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-08-28 21:09:23]

Thanks! PTAL.

https://codereview.chromium.org/2238543002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/ScriptLoader.h (right):

https://codereview.chromium.org/2238543002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/ScriptLoader.h:129:
WTF::Optional<ScriptRunner::ExecutionType> m_asyncExecType;
On 2016/08/26 at 10:01:48, kouhei wrote:
> Would you add another ExecutionType instead of WTF::Optional?

Sure. I also renamed the enum to AsyncExecutionType, since it's specific to
async scripts, and fixed the enum naming to match the blink style guide
(AsyncExecution rather than ASYNC_EXECUTION). PTAL, thanks!

[commit-bot: I haz the power, 2016-08-28 21:50:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-28 21:50:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kouhei (in TOK), 2016-08-29 00:20:49]

lgtm. Thanks!

https://codereview.chromium.org/2238543002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/ScriptRunner.h (right):

https://codereview.chromium.org/2238543002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/ScriptRunner.h:51: enum AsyncExecutionType {
NoExecType, AsyncExecution, InOrderExecution };
Optional: enum class is preferred over enum.
enum class AsyncExecutionType { None, Async, InOrder }; ?

[Bryan McQuade, 2016-08-29 19:44:24]

On 2016/08/29 at 00:20:49, kouhei wrote:
> lgtm. Thanks!
> 
>
https://codereview.chromium.org/2238543002/diff/200001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/dom/ScriptRunner.h (right):
> 
>
https://codereview.chromium.org/2238543002/diff/200001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/dom/ScriptRunner.h:51: enum AsyncExecutionType
{ NoExecType, AsyncExecution, InOrderExecution };
> Optional: enum class is preferred over enum.
> enum class AsyncExecutionType { None, Async, InOrder }; ?

Good suggestion, done, thanks!

[Bryan McQuade, 2016-08-29 19:44:51]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 20:11:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:20:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:20:44]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-08-30 12:12:49]

bmcquade@chromium.org changed reviewers:
- japhet@chromium.org

[Bryan McQuade, 2016-09-06 19:07:48]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2016-09-06 19:09:21]

csharrison, PTAL, thanks!

[Charlie Harrison, 2016-09-06 19:10:29]

On 2016/09/06 19:09:21, Bryan McQuade wrote:
> csharrison, PTAL, thanks!

I'll try to get to this tomorrow. Thanks for the patch!

[Charlie Harrison, 2016-09-07 14:57:37]

Looks like you need to update histograms.xml as well.

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File chrome/browser/page_load_metrics/metrics_web_contents_observer.cc (right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/metrics_web_contents_observer.cc:139: <<
"Invalid "
Fix up the formatting here.

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
(right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc:138:
"PageLoad.ParseTiming.ParseBlockedOnScriptExecution.Background";
I wonder if we can hold off on adding bg histograms until we know we need them?

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File
chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
(right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc:92:
if (!inout_timing->parse_blocked_on_script_execution_duration)
Optional nit: It makes me nervous to have multi-line declarations with a bare
"if" with no {}. This a personal style thing though and it's already throughout
this function so it's fine to keep it.

[Bryan McQuade, 2016-09-07 18:25:39]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[Bryan McQuade, 2016-09-07 18:26:09]

Thanks! PTAL.

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File chrome/browser/page_load_metrics/metrics_web_contents_observer.cc (right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/metrics_web_contents_observer.cc:139: <<
"Invalid "
On 2016/09/07 at 14:57:37, Charlie Harrison wrote:
> Fix up the formatting here.

I think this is the best formatting option for better or worse. The next line is
one big word "parse_blocked_on_script_execution_from_document_write_duration"
which fits within 80 cols but not when pulled up to the previous line. Pulling
<< "Invalid " up on the previous line means that the following line
parse_blocked_on_script_execution_from_document_write_duration is indented
further which means it doesn't fit in 80 cols.

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
(right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc:138:
"PageLoad.ParseTiming.ParseBlockedOnScriptExecution.Background";
On 2016/09/07 at 14:57:37, Charlie Harrison wrote:
> I wonder if we can hold off on adding bg histograms until we know we need
them?

I like to have them just so I can understand the ratio of events that happen for
fg/bg pages. If for instance 90% of events happen for pages that are
backgrounded, that's important to know. The distributions are less interesting
but can be useful. I think bg histograms are worth adding for the core
histograms, but optional / not needed for the client histograms.

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File
chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
(right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc:92:
if (!inout_timing->parse_blocked_on_script_execution_duration)
On 2016/09/07 at 14:57:37, Charlie Harrison wrote:
> Optional nit: It makes me nervous to have multi-line declarations with a bare
"if" with no {}. This a personal style thing though and it's already throughout
this function so it's fine to keep it.

Sure, makes sense. I fixed a few other cases as well.

[commit-bot: I haz the power, 2016-09-07 18:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-09-07 18:32:51]

I think you still need an update to histograms.xml

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File chrome/browser/page_load_metrics/metrics_web_contents_observer.cc (right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/metrics_web_contents_observer.cc:139: <<
"Invalid "
On 2016/09/07 18:26:09, Bryan McQuade wrote:
> On 2016/09/07 at 14:57:37, Charlie Harrison wrote:
> > Fix up the formatting here.
> 
> I think this is the best formatting option for better or worse. The next line
is
> one big word "parse_blocked_on_script_execution_from_document_write_duration"
> which fits within 80 cols but not when pulled up to the previous line. Pulling
> << "Invalid " up on the previous line means that the following line
> parse_blocked_on_script_execution_from_document_write_duration is indented
> further which means it doesn't fit in 80 cols.

Ah you're right. Missed the underscores here. Sorry for the noise.

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
(right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc:138:
"PageLoad.ParseTiming.ParseBlockedOnScriptExecution.Background";
On 2016/09/07 18:26:09, Bryan McQuade wrote:
> On 2016/09/07 at 14:57:37, Charlie Harrison wrote:
> > I wonder if we can hold off on adding bg histograms until we know we need
> them?
> 
> I like to have them just so I can understand the ratio of events that happen
for
> fg/bg pages. If for instance 90% of events happen for pages that are
> backgrounded, that's important to know. The distributions are less interesting
> but can be useful. I think bg histograms are worth adding for the core
> histograms, but optional / not needed for the client histograms.

If you truly only care about ratio of total events then can't these be trivially
replaced with the parse duration BG histograms? I just worry that we're adding
so many histograms we'll never end up looking at.

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File
chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
(right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc:92:
if (!inout_timing->parse_blocked_on_script_execution_duration)
On 2016/09/07 18:26:09, Bryan McQuade wrote:
> On 2016/09/07 at 14:57:37, Charlie Harrison wrote:
> > Optional nit: It makes me nervous to have multi-line declarations with a
bare
> "if" with no {}. This a personal style thing though and it's already
throughout
> this function so it's fine to keep it.
> 
> Sure, makes sense. I fixed a few other cases as well.

Thanks!

[commit-bot: I haz the power, 2016-09-07 21:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:49:20]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-09-07 23:05:08]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 23:06:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-07 23:07:58]

bmcquade@chromium.org changed reviewers:
+ holte@chromium.org

[Bryan McQuade, 2016-09-07 23:07:59]

I updated histograms.xml. PTAL, thanks!

holte, PTAL for histograms.xml, thanks!

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
File
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
(right):

https://codereview.chromium.org/2238543002/diff/220001/chrome/browser/page_lo...
chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc:138:
"PageLoad.ParseTiming.ParseBlockedOnScriptExecution.Background";
On 2016/09/07 at 18:32:50, Charlie Harrison wrote:
> On 2016/09/07 18:26:09, Bryan McQuade wrote:
> > On 2016/09/07 at 14:57:37, Charlie Harrison wrote:
> > > I wonder if we can hold off on adding bg histograms until we know we need
> > them?
> > 
> > I like to have them just so I can understand the ratio of events that happen
for
> > fg/bg pages. If for instance 90% of events happen for pages that are
> > backgrounded, that's important to know. The distributions are less
interesting
> > but can be useful. I think bg histograms are worth adding for the core
> > histograms, but optional / not needed for the client histograms.
> 
> If you truly only care about ratio of total events then can't these be
trivially replaced with the parse duration BG histograms? I just worry that
we're adding so many histograms we'll never end up looking at.

Yeah, you're right - we should get the same counts for parseduration.background,
so we don't need this. Removed.

[Steven Holte, 2016-09-07 23:15:44]

histograms lgtm

[Charlie Harrison, 2016-09-08 00:24:57]

Thanks. page_load_metrics lgtm

[commit-bot: I haz the power, 2016-09-08 03:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 03:33:36]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-09-08 11:27:46]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-09-08 11:27:47]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2238543002/#ps260001
(title: "address comments")

[commit-bot: I haz the power, 2016-09-08 11:28:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 11:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 11:32:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bryan McQuade, 2016-09-08 11:53:35]

bmcquade@chromium.org changed reviewers:
+ tsepez@chromium.org

[Bryan McQuade, 2016-09-08 11:53:52]

bmcquade@chromium.org changed reviewers:
- tsepez@chromium.org

[Bryan McQuade, 2016-09-08 11:53:53]

tsepez, PTAL for page_load_metrics_messages.*, thanks!

[Bryan McQuade, 2016-09-08 11:54:13]

bmcquade@chromium.org changed reviewers:
+ tsepez@chromium.org

[Bryan McQuade, 2016-09-08 11:54:14]

tsepez, PTAL for page_load_metrics_messages.*, thanks!

[Tom Sepez, 2016-09-08 17:39:36]

messages LGTM

[Bryan McQuade, 2016-09-08 17:40:27]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-09-08 17:41:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:47:10]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-09-08 17:49:53]

Description was changed from

==========
Instrument parser blocking script execution time.

We already track parser blocking script load time. This patch
adds support for tracking parser blocking script execution time.

We have a few use cases for this:
* allows us to understand % of parse time blocked on script exec
  time, to better understand whether script exec time is a
  significant contributor to page load time
* having this would have helped us to catch a regression that took
  hours of time to identify the root cause of (crbug.com/608424)
* there is a desire to understand how much time scripts inserted
  via doc.write spend executing, in addition to loading

BUG=640260
==========

to

==========
Instrument parser blocking script execution time.

We already track parser blocking script load time. This patch
adds support for tracking parser blocking script execution time.

We have a few use cases for this:
* allows us to understand % of parse time blocked on script exec
  time, to better understand whether script exec time is a
  significant contributor to page load time
* having this would have helped us to catch a regression that took
  hours of time to identify the root cause of (crbug.com/608424)
* there is a desire to understand how much time scripts inserted
  via doc.write spend executing, in addition to loading

BUG=640260

Committed: https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473
Cr-Commit-Position: refs/heads/master@{#417330}
==========

[commit-bot: I haz the power, 2016-09-08 17:49:55]

Patchset 14 (id:??) landed as
https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473
Cr-Commit-Position: refs/heads/master@{#417330}