Instrument parser blocking script execution time.

chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
 
 #include <algorithm>
 #include <ostream>
 #include <string>
 #include <utility>
@@ skipping 97 matching lines @@
 
   if (timing.parse_stop) {
     const base::TimeDelta parse_duration =
         timing.parse_stop.value() - timing.parse_start.value();
     if (timing.parse_blocked_on_script_load_duration > parse_duration) {
       NOTREACHED() << "Invalid parse_blocked_on_script_load_duration "
                    << timing.parse_blocked_on_script_load_duration
                    << " for parse duration " << parse_duration;
       return false;
     }
+    if (timing.parse_blocked_on_script_execution_duration > parse_duration) {
+      NOTREACHED() << "Invalid parse_blocked_on_script_execution_duration "
+                   << timing.parse_blocked_on_script_execution_duration
+                   << " for parse duration " << parse_duration;
+      return false;
+    }
   }
 
   if (timing.parse_blocked_on_script_load_from_document_write_duration >
       timing.parse_blocked_on_script_load_duration) {
     NOTREACHED()
         << "Invalid parse_blocked_on_script_load_from_document_write_duration "
         << timing.parse_blocked_on_script_load_from_document_write_duration
         << " for parse_blocked_on_script_load_duration "
         << timing.parse_blocked_on_script_load_duration;
     return false;
   }
 
+  if (timing.parse_blocked_on_script_execution_from_document_write_duration >
+      timing.parse_blocked_on_script_execution_duration) {
+    NOTREACHED()
+        << "Invalid "

[Charlie Harrison, 2016/09/07 14:57:37]

Fix up the formatting here.

[Bryan McQuade, 2016/09/07 18:26:09]

I think this is the best formatting option for better or worse. The next line is
one big word "parse_blocked_on_script_execution_from_document_write_duration"
which fits within 80 cols but not when pulled up to the previous line. Pulling
<< "Invalid " up on the previous line means that the following line
parse_blocked_on_script_execution_from_document_write_duration is indented
further which means it doesn't fit in 80 cols.

[Charlie Harrison, 2016/09/07 18:32:50]

Ah you're right. Missed the underscores here. Sorry for the noise.

+           "parse_blocked_on_script_execution_from_document_write_duration "
+        << timing.parse_blocked_on_script_execution_from_document_write_duration
+        << " for parse_blocked_on_script_execution_duration "
+        << timing.parse_blocked_on_script_execution_duration;
+    return false;
+  }
+
   if (!EventsInOrder(timing.parse_stop,
                      timing.dom_content_loaded_event_start)) {
     NOTREACHED() << "Invalid parse_stop " << timing.parse_stop
                  << " for dom_content_loaded_event_start "
                  << timing.dom_content_loaded_event_start;
     return false;
   }
 
   if (!EventsInOrder(timing.dom_content_loaded_event_start,
                      timing.load_event_start)) {
@@ skipping 912 matching lines @@
     if (navigation_handle->IsSamePage() || navigation_handle->IsErrorPage())
       return false;
     const std::string& mime_type = web_contents()->GetContentsMimeType();
     if (mime_type != "text/html" && mime_type != "application/xhtml+xml")
       return false;
   }
   return true;
 }
 
 }  // namespace page_load_metrics