Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5312)

Unified Diff: chrome/common/page_load_metrics/page_load_timing.h

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/page_load_metrics/page_load_timing.h
diff --git a/chrome/common/page_load_metrics/page_load_timing.h b/chrome/common/page_load_metrics/page_load_timing.h
index bb67edc2c15c7262cc10435cd3af6ee6acf01243..2050af4934a34dbd88213898976ef54b91bd879c 100644
--- a/chrome/common/page_load_metrics/page_load_timing.h
+++ b/chrome/common/page_load_metrics/page_load_timing.h
@@ -77,6 +77,21 @@ struct PageLoadTiming {
base::Optional<base::TimeDelta>
parse_blocked_on_script_load_from_document_write_duration;
+ // Sum of times when the parser is executing a script. This duration takes
+ // place between parser_start and parser_stop, and thus must be less than or
+ // equal to parser_stop - parser_start. Note that this value may be updated
+ // multiple times during the period between parse_start and parse_stop.
+ base::Optional<base::TimeDelta> parse_blocked_on_script_execution_duration;
+
+ // Sum of times when the parser is executing a script that was inserted from
+ // document.write. This duration must be less than or equal to
+ // parse_blocked_on_script_load_duration. Note that this value may be updated
+ // multiple times during the period between parse_start and parse_stop. Note
+ // that some uncommon cases where scripts are loaded via document.write are
+ // not currently covered by this field. See crbug/600711 for details.
+ base::Optional<base::TimeDelta>
+ parse_blocked_on_script_execution_from_document_write_duration;
+
// If you add additional members, also be sure to update operator==,
// page_load_metrics_messages.h, and IsEmpty().
};
« no previous file with comments | « chrome/common/page_load_metrics/page_load_metrics_messages.h ('k') | chrome/common/page_load_metrics/page_load_timing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698