chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2238543002: Instrument parser blocking script execution time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index 36632e7e3a7b4aee01240014d0137a4b3af78b79..25a6165a38f4d912696e7b404a4cecdc05f3b3b2 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -72,15 +72,19 @@ TEST_F(CorePageLoadMetricsObserverTest, SingleMetricAfterCommit) {

base::TimeDelta first_layout = base::TimeDelta::FromMilliseconds(1);

base::TimeDelta parse_start = base::TimeDelta::FromMilliseconds(1);

base::TimeDelta parse_stop = base::TimeDelta::FromMilliseconds(5);

- base::TimeDelta parse_script_block_duration =

+ base::TimeDelta parse_script_load_duration =

base::TimeDelta::FromMilliseconds(3);

+ base::TimeDelta parse_script_exec_duration =

+ base::TimeDelta::FromMilliseconds(1);

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);

timing.first_layout = first_layout;

timing.parse_start = parse_start;

timing.parse_stop = parse_stop;

- timing.parse_blocked_on_script_load_duration = parse_script_block_duration;

+ timing.parse_blocked_on_script_load_duration = parse_script_load_duration;

+ timing.parse_blocked_on_script_execution_duration =

+ parse_script_exec_duration;

PopulateRequiredTimingFields(&timing);

NavigateAndCommit(GURL(kDefaultTestUrl));

@@ -102,7 +106,10 @@ TEST_F(CorePageLoadMetricsObserverTest, SingleMetricAfterCommit) {

(parse_stop - parse_start).InMilliseconds(), 1);

histogram_tester().ExpectBucketCount(

internal::kHistogramParseBlockedOnScriptLoad,

- parse_script_block_duration.InMilliseconds(), 1);

+ parse_script_load_duration.InMilliseconds(), 1);

+ histogram_tester().ExpectBucketCount(

+ internal::kHistogramParseBlockedOnScriptExecution,

+ parse_script_exec_duration.InMilliseconds(), 1);

histogram_tester().ExpectTotalCount(internal::kHistogramFirstTextPaint, 0);

}