Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 4bfceb1be9cea2e34bbb2e124a01fc4de54ca348..a559ced11d2d3dd6f5c6f562d996d9630a2f59aa 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -132,6 +132,10 @@ const char kHistogramParseBlockedOnScriptLoadDocumentWrite[] =
const char kBackgroundHistogramParseBlockedOnScriptLoadDocumentWrite[] =
"PageLoad.ParseTiming.ParseBlockedOnScriptLoadFromDocumentWrite."
"Background";
+const char kHistogramParseBlockedOnScriptExecution[] =
+ "PageLoad.ParseTiming.ParseBlockedOnScriptExecution";
+const char kHistogramParseBlockedOnScriptExecutionDocumentWrite[] =
+ "PageLoad.ParseTiming.ParseBlockedOnScriptExecutionFromDocumentWrite";
const char kHistogramFirstContentfulPaintNoStore[] =
"PageLoad.PaintTiming.NavigationToFirstContentfulPaint.NoStore";
@@ -455,6 +459,13 @@ void CorePageLoadMetricsObserver::OnParseStop(
internal::kHistogramParseBlockedOnScriptLoadDocumentWrite,
timing.parse_blocked_on_script_load_from_document_write_duration
.value());
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramParseBlockedOnScriptExecution,
+ timing.parse_blocked_on_script_execution_duration.value());
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramParseBlockedOnScriptExecutionDocumentWrite,
+ timing.parse_blocked_on_script_execution_from_document_write_duration
+ .value());
int total_requests = info.num_cache_requests + info.num_network_requests;
if (total_requests) {
@@ -477,7 +488,6 @@ void CorePageLoadMetricsObserver::OnParseStop(
parse_duration);
}
}
-
} else {
PAGE_LOAD_HISTOGRAM(internal::kBackgroundHistogramParseDuration,
parse_duration);

Powered by Google App Engine
This is Rietveld 408576698