Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5887)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index f71bfafe964a7bb474d7d11c974bfc342fb80223..86a76e25c8ed3f35079a4c580c73489dbca8cff0 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -115,6 +115,12 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
<< " for parse duration " << parse_duration;
return false;
}
+ if (timing.parse_blocked_on_script_execution_duration > parse_duration) {
+ NOTREACHED() << "Invalid parse_blocked_on_script_execution_duration "
+ << timing.parse_blocked_on_script_execution_duration
+ << " for parse duration " << parse_duration;
+ return false;
+ }
}
if (timing.parse_blocked_on_script_load_from_document_write_duration >
@@ -127,6 +133,17 @@ bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
return false;
}
+ if (timing.parse_blocked_on_script_execution_from_document_write_duration >
+ timing.parse_blocked_on_script_execution_duration) {
+ NOTREACHED()
+ << "Invalid "
+ "parse_blocked_on_script_execution_from_document_write_duration "
+ << timing.parse_blocked_on_script_execution_from_document_write_duration
+ << " for parse_blocked_on_script_execution_duration "
+ << timing.parse_blocked_on_script_execution_duration;
+ return false;
+ }
+
if (!EventsInOrder(timing.parse_stop,
timing.dom_content_loaded_event_start)) {
NOTREACHED() << "Invalid parse_stop " << timing.parse_stop
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698