chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2238543002: Instrument parser blocking script execution time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 153228f9b3f71447394cac069c0e656a8d414e14..9b888bf851ddb6034855fed498ff5df1ee157aa4 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -89,10 +89,21 @@ void PageLoadMetricsObserverTestHarness::PopulateRequiredTimingFields(

if (inout_timing->parse_start) {

if (!inout_timing->parse_blocked_on_script_load_duration)

inout_timing->parse_blocked_on_script_load_duration = base::TimeDelta();

+ if (!inout_timing->parse_blocked_on_script_execution_duration) {

+ inout_timing->parse_blocked_on_script_execution_duration =

+ base::TimeDelta();

+ }

if (!inout_timing

- ->parse_blocked_on_script_load_from_document_write_duration)

+ ->parse_blocked_on_script_load_from_document_write_duration) {

inout_timing->parse_blocked_on_script_load_from_document_write_duration =

base::TimeDelta();

+ }

+ if (!inout_timing

+ ->parse_blocked_on_script_execution_from_document_write_duration) {

+ inout_timing

+ ->parse_blocked_on_script_execution_from_document_write_duration =

+ base::TimeDelta();

+ }

}