Remove calls to deprecated MessageLoop methods on Windows and Linux.

Remove calls to deprecated MessageLoop methods on Windows and Linux.

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941
Cr-Commit-Position: refs/heads/master@{#414442}

[fdoray, 2016-08-04 14:27:26]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

With this CL, there is no remaining call to these methods on Windows
and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
==========

to

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

With this CL, there is no remaining call to these methods on Windows
and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[fdoray, 2016-08-04 14:27:27]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

With this CL, there is no remaining call to these methods on Windows
and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

With this CL, there is no remaining call to these methods on Windows
and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[fdoray, 2016-08-04 14:29:07]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 14:29:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 14:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 14:35:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[fdoray, 2016-08-04 17:43:58]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 17:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-08-04 18:48:19]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2016-08-04 18:48:21]

gab@: Please take a first look.

https://codereview.chromium.org/2211473003/diff/20001/content/browser/downloa...
File content/browser/download/download_manager_impl_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/content/browser/downloa...
content/browser/download/download_manager_impl_unittest.cc:546:
ASSERT_EQ(nullptr, mock_download_item_factory_.get());
I removed the duplicated line...
I'm not convinced that the second RunUntilIdle() below is useful either.

https://codereview.chromium.org/2211473003/diff/20001/content/browser/site_in...
File content/browser/site_instance_impl_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/content/browser/site_in...
content/browser/site_instance_impl_unittest.cc:141:
base::RunLoop().RunUntilIdle();
Why are there 2 calls?

[commit-bot: I haz the power, 2016-08-04 19:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:35:06]

Dry run: This issue passed the CQ dry run.

[gab, 2016-08-05 01:09:58]

lg % few comments

PS: This script is crazy cool :-)

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
File base/message_loop/message_loop_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
base/message_loop/message_loop_unittest.cc:273: void
RecursiveFuncWin(MessageLoop* target,
Take SingleThreadTaskRunner* instead

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
base/message_loop/message_loop_unittest.cc:481: MessageLoop* thread_loop =
thread.message_loop();
unused var

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
base/message_loop/message_loop_unittest.cc:522: MessageLoop* thread_loop =
thread.message_loop();
unused var

https://codereview.chromium.org/2211473003/diff/20001/components/suggestions/...
File components/suggestions/suggestions_service_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/components/suggestions/...
components/suggestions/suggestions_service_unittest.cc:597:
base::RunLoop().RunUntilIdle();
This doesn't make sense anymore (I guess the logic was already only using
current message loop but it should be addressed in its own CL with this code's
owners)

https://codereview.chromium.org/2211473003/diff/20001/content/browser/downloa...
File content/browser/download/download_manager_impl_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/content/browser/downloa...
content/browser/download/download_manager_impl_unittest.cc:546:
ASSERT_EQ(nullptr, mock_download_item_factory_.get());
On 2016/08/04 18:48:21, fdoray wrote:
> I removed the duplicated line...
> I'm not convinced that the second RunUntilIdle() below is useful either.

Yea, second RunUntilIdle() should be irrelevant, let's remove it.

https://codereview.chromium.org/2211473003/diff/20001/content/browser/site_in...
File content/browser/site_instance_impl_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/content/browser/site_in...
content/browser/site_instance_impl_unittest.cc:141:
base::RunLoop().RunUntilIdle();
On 2016/08/04 18:48:21, fdoray wrote:
> Why are there 2 calls?

Probably because the developer thought he was flushing two different things in
old code. Worth a separate CL with its owners IMO to make sure they're aware it
didn't do what they thought it did.

https://codereview.chromium.org/2211473003/diff/20001/extensions/shell/test/s...
File extensions/shell/test/shell_test.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/extensions/shell/test/s...
extensions/shell/test/shell_test.cc:61: base::RunLoop().RunUntilIdle();
Why didn't the script add a DCHECK IsMessageLoopForUI here?

https://codereview.chromium.org/2211473003/diff/20001/media/audio/win/audio_l...
File media/audio/win/audio_low_latency_input_win_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/media/audio/win/audio_l...
media/audio/win/audio_low_latency_input_win_unittest.cc:433:
base::RunLoop().Run();
run_loop.Run() ?

https://codereview.chromium.org/2211473003/diff/20001/net/http/transport_secu...
File net/http/transport_security_persister_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/net/http/transport_secu...
net/http/transport_security_persister_unittest.cc:31:
~TransportSecurityPersisterTest() override { base::RunLoop().RunUntilIdle(); }
Missing DCHECK ForIO

[fdoray, 2016-08-05 16:08:42]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 16:09:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-08-05 16:10:34]

fdoray@chromium.org changed reviewers:
+ robliao@chromium.org

[fdoray, 2016-08-05 16:10:36]

robliao@: PTAL (gab is OOO this afternoon)

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
File base/message_loop/message_loop_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
base/message_loop/message_loop_unittest.cc:273: void
RecursiveFuncWin(MessageLoop* target,
On 2016/08/05 01:09:57, gab wrote:
> Take SingleThreadTaskRunner* instead

Done.

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
base/message_loop/message_loop_unittest.cc:481: MessageLoop* thread_loop =
thread.message_loop();
On 2016/08/05 01:09:57, gab wrote:
> unused var

Done.

https://codereview.chromium.org/2211473003/diff/20001/base/message_loop/messa...
base/message_loop/message_loop_unittest.cc:522: MessageLoop* thread_loop =
thread.message_loop();
On 2016/08/05 01:09:57, gab wrote:
> unused var

Done.

https://codereview.chromium.org/2211473003/diff/20001/components/suggestions/...
File components/suggestions/suggestions_service_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/components/suggestions/...
components/suggestions/suggestions_service_unittest.cc:597:
base::RunLoop().RunUntilIdle();
On 2016/08/05 01:09:57, gab wrote:
> This doesn't make sense anymore (I guess the logic was already only using
> current message loop but it should be addressed in its own CL with this code's
> owners)

Multiple RunUntilIdle in a row really doesn't make sense... after one call, the
MessageLoop is idle and the next RunUntilIdle won't do anything. Addressed in a
separate CL https://codereview.chromium.org/2212223003/

https://codereview.chromium.org/2211473003/diff/20001/content/browser/downloa...
File content/browser/download/download_manager_impl_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/content/browser/downloa...
content/browser/download/download_manager_impl_unittest.cc:546:
ASSERT_EQ(nullptr, mock_download_item_factory_.get());
On 2016/08/05 01:09:57, gab wrote:
> On 2016/08/04 18:48:21, fdoray wrote:
> > I removed the duplicated line...
> > I'm not convinced that the second RunUntilIdle() below is useful either.
> 
> Yea, second RunUntilIdle() should be irrelevant, let's remove it.

Done.

https://codereview.chromium.org/2211473003/diff/20001/content/browser/site_in...
File content/browser/site_instance_impl_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/content/browser/site_in...
content/browser/site_instance_impl_unittest.cc:141:
base::RunLoop().RunUntilIdle();
On 2016/08/05 01:09:57, gab wrote:
> On 2016/08/04 18:48:21, fdoray wrote:
> > Why are there 2 calls?
> 
> Probably because the developer thought he was flushing two different things in
> old code. Worth a separate CL with its owners IMO to make sure they're aware
it
> didn't do what they thought it did.

Done. https://codereview.chromium.org/2219053002/

https://codereview.chromium.org/2211473003/diff/20001/extensions/shell/test/s...
File extensions/shell/test/shell_test.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/extensions/shell/test/s...
extensions/shell/test/shell_test.cc:61: base::RunLoop().RunUntilIdle();
On 2016/08/05 01:09:57, gab wrote:
> Why didn't the script add a DCHECK IsMessageLoopForUI here?

Done. I added these DCHECKs manually.

https://codereview.chromium.org/2211473003/diff/20001/media/audio/win/audio_l...
File media/audio/win/audio_low_latency_input_win_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/media/audio/win/audio_l...
media/audio/win/audio_low_latency_input_win_unittest.cc:433:
base::RunLoop().Run();
On 2016/08/05 01:09:57, gab wrote:
> run_loop.Run() ?

Done.

https://codereview.chromium.org/2211473003/diff/20001/net/http/transport_secu...
File net/http/transport_security_persister_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/20001/net/http/transport_secu...
net/http/transport_security_persister_unittest.cc:31:
~TransportSecurityPersisterTest() override { base::RunLoop().RunUntilIdle(); }
On 2016/08/05 01:09:57, gab wrote:
> Missing DCHECK ForIO

Done.

[gab, 2016-08-05 16:18:42]

Diff lgtm (you can spare robliao ;-))

https://codereview.chromium.org/2211473003/diff/80001/content/browser/downloa...
File content/browser/download/download_manager_impl_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/80001/content/browser/downloa...
content/browser/download/download_manager_impl_unittest.cc:546:
ASSERT_FALSE(mock_download_item_factory_.get());
No .get()

[commit-bot: I haz the power, 2016-08-05 16:19:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 16:20:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-08-05 17:07:12]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:07:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-08-05 18:18:04]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

With this CL, there is no remaining call to these methods on Windows
and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

With this CL, there is no remaining call to these methods on Windows
and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[fdoray, 2016-08-05 18:18:04]

fdoray@chromium.org changed reviewers:
- robliao@chromium.org

[fdoray, 2016-08-05 18:19:15]

fdoray@chromium.org changed reviewers:
+ agl@chromium.org, amistry@chromium.org, bbudge@chromium.org, ben@chromium.org,
caitkp@chromium.org, chcunningham@chromium.org, derat@chromium.org,
digit@chromium.org, dtrainor@chromium.org, garykac@chromium.org,
hashimoto@chromium.org, jam@chromium.org, jochen@chromium.org,
jschuh@chromium.org, reillyg@chromium.org, sadrul@chromium.org,
sergeyu@chromium.org, sievers@chromium.org, thestig@chromium.org

[fdoray, 2016-08-05 18:19:17]

OWNERS, can I get a rubber stamp LGTM for this CL? Thanks!

ash derat@chromium.org
base thestig@chromium.org
blimp dtrainor@chromium.org
chrome jochen@chromium.org
components caitkp@chromium.org
content jochen@chromium.org
dbus hashimoto@chromium.org
device reillyg@chromium.org
extensions reillyg@chromium.org
gpu sievers@chromium.org
ipc amistry@chromium.org
jingle sergeyu@chromium.org
mash ben@chromium.org
media chcunningham@chromium.org
mojo ben@chromium.org
net agl@chromium.org
ppapi bbudge@chromium.org
remoting garykac@chromium.org
sandbox jschuh@chromium.org
services jam@chromium.org
tools/android digit@chromium.org
ui sadrul@chromium.org

[Reilly Grant (use Gerrit), 2016-08-05 18:24:45]

lgtm with a nit

https://codereview.chromium.org/2211473003/diff/100001/device/bluetooth/bluez...
File device/bluetooth/bluez/bluetooth_bluez_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:1112: .Run();  // Run the
loop, as there should have been a D-Bus call.
This and below is an unfortunately wrapping. Can you move this comment to its
own line as it is in the hunk above.

[commit-bot: I haz the power, 2016-08-05 18:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:40:24]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-05 18:40:47]

base/ and chrome/ lgtm

Please consider splitting up large CLs when possible. e.g. This can a set of
separate CLs: [m-n]*, [p-t]*, ui, etc.

[Daniel Erat, 2016-08-05 18:55:14]

https://codereview.chromium.org/2211473003/diff/100001/ash/shell/content/clie...
File ash/shell/content/client/shell_browser_main_parts.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ash/shell/content/clie...
ash/shell/content/client/shell_browser_main_parts.cc:19: #include
"base/message_loop/message_loop.h"
nit: can you remove this include?

https://codereview.chromium.org/2211473003/diff/100001/ash/test/shelf_view_te...
File ash/test/shelf_view_test_api.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ash/test/shelf_view_te...
ash/test/shelf_view_test_api.cc:29:
base::MessageLoop::current()->QuitWhenIdle();
should this be calling QuitWhenIdle() on the RunLoop instead? (doesn't need to
happen now if it's still safe to do this.)

[bbudge, 2016-08-05 19:13:30]

ppapi lgtm w/3 comments.

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
File ppapi/nacl_irt/irt_pnacl_translator_compile.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
ppapi/nacl_irt/irt_pnacl_translator_compile.cc:103: base::MessageLoop loop;
Do we still need this?

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
File ppapi/nacl_irt/irt_pnacl_translator_link.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
ppapi/nacl_irt/irt_pnacl_translator_link.cc:74: base::MessageLoop loop;
Ditto.

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_ppa...
File ppapi/nacl_irt/irt_ppapi.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_ppa...
ppapi/nacl_irt/irt_ppapi.cc:36: base::MessageLoop loop;
Ditto.

[jam, 2016-08-05 19:56:43]

lgtm

https://codereview.chromium.org/2211473003/diff/100001/services/navigation/co...
File services/navigation/content_client/browser_main_parts.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/services/navigation/co...
services/navigation/content_client/browser_main_parts.cc:7: #include
"base/message_loop/message_loop.h"
nit: remove this and also in other files?

[Sergey Ulanov, 2016-08-05 22:54:43]

remoting lgtm

[Sergey Ulanov, 2016-08-05 22:55:18]

On 2016/08/05 22:54:43, Sergey Ulanov wrote:
> remoting lgtm

jingle lgtm as well.

[fdoray, 2016-08-05 23:40:38]

fdoray@chromium.org changed reviewers:
- amistry@chromium.org

[fdoray, 2016-08-05 23:41:37]

CR feedback addressed

ash derat@chromium.org
base thestig@chromium.org
blimp dtrainor@chromium.org
chrome jochen@chromium.org
components caitkp@chromium.org
content jochen@chromium.org
dbus hashimoto@chromium.org
device reillyg@chromium.org
extensions reillyg@chromium.org
gpu sievers@chromium.org
ipc jam@chromium.org
jingle sergeyu@chromium.org
mash ben@chromium.org
media chcunningham@chromium.org
mojo ben@chromium.org
net agl@chromium.org
ppapi bbudge@chromium.org
remoting garykac@chromium.org
sandbox jschuh@chromium.org
services jam@chromium.org
tools/android digit@chromium.org
ui sadrul@chromium.org

https://codereview.chromium.org/2211473003/diff/100001/ash/shell/content/clie...
File ash/shell/content/client/shell_browser_main_parts.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ash/shell/content/clie...
ash/shell/content/client/shell_browser_main_parts.cc:19: #include
"base/message_loop/message_loop.h"
On 2016/08/05 18:55:14, Daniel Erat wrote:
> nit: can you remove this include?

Had to move it inside #if defined(OS_ANDROID) instead of removing it because
it's still used in PostMainMessageLoopStart.

https://codereview.chromium.org/2211473003/diff/100001/ash/test/shelf_view_te...
File ash/test/shelf_view_test_api.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ash/test/shelf_view_te...
ash/test/shelf_view_test_api.cc:29:
base::MessageLoop::current()->QuitWhenIdle();
On 2016/08/05 18:55:14, Daniel Erat wrote:
> should this be calling QuitWhenIdle() on the RunLoop instead? (doesn't need to
> happen now if it's still safe to do this.)

This will be done in another refactoring phase. Our goal is to remove
MessageLoop::Run() as soon as possible so that people have no choice to use
RunLoop (and hopefully will call QuitWhenIdle on that RunLoop). Once this is
done, we will migrate calls to MessageLoop::QuitWhenIdle (which is trickier to
do).

https://codereview.chromium.org/2211473003/diff/100001/device/bluetooth/bluez...
File device/bluetooth/bluez/bluetooth_bluez_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/device/bluetooth/bluez...
device/bluetooth/bluez/bluetooth_bluez_unittest.cc:1112: .Run();  // Run the
loop, as there should have been a D-Bus call.
On 2016/08/05 18:24:45, Reilly Grant wrote:
> This and below is an unfortunately wrapping. Can you move this comment to its
> own line as it is in the hunk above.

Done.

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
File ppapi/nacl_irt/irt_pnacl_translator_compile.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
ppapi/nacl_irt/irt_pnacl_translator_compile.cc:103: base::MessageLoop loop;
On 2016/08/05 19:13:30, bbudge wrote:
> Do we still need this?

Yes. RunLoop::Run() has to be called in the scope of a MessageLoop.

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
File ppapi/nacl_irt/irt_pnacl_translator_link.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_pna...
ppapi/nacl_irt/irt_pnacl_translator_link.cc:74: base::MessageLoop loop;
On 2016/08/05 19:13:30, bbudge wrote:
> Ditto.

Ditto.

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_ppa...
File ppapi/nacl_irt/irt_ppapi.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/ppapi/nacl_irt/irt_ppa...
ppapi/nacl_irt/irt_ppapi.cc:36: base::MessageLoop loop;
On 2016/08/05 19:13:30, bbudge wrote:
> Ditto.

Ditto.

https://codereview.chromium.org/2211473003/diff/100001/services/navigation/co...
File services/navigation/content_client/browser_main_parts.cc (right):

https://codereview.chromium.org/2211473003/diff/100001/services/navigation/co...
services/navigation/content_client/browser_main_parts.cc:7: #include
"base/message_loop/message_loop.h"
On 2016/08/05 19:56:43, jam wrote:
> nit: remove this and also in other files?

Done. Our script should have removed this include in most files where it's not
required. It didn't remove it here because it found the "MessageLoop" string in
the file (the heuristic could be improved but works most of the time).

[Daniel Erat, 2016-08-06 00:28:27]

lgtm for ash/

[agl, 2016-08-06 00:44:01]

https://codereview.chromium.org/2211473003/diff/120001/net/tools/get_server_t...
File net/tools/get_server_time/get_server_time.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/net/tools/get_server_t...
net/tools/get_server_time/get_server_time.cc:256: base::RunLoop().Run();
The |main_loop| variable is still created and passed to
TrivialURLRequestContextGetter, but now never run?

https://codereview.chromium.org/2211473003/diff/120001/net/tools/net_watcher/...
File net/tools/net_watcher/net_watcher.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/net/tools/net_watcher/...
net/tools/net_watcher/net_watcher.cc:218: base::RunLoop().Run();
This one seems a little suspect, although I'm not sure. The |network_loop|
variable is still created and passed to a function, but never run?

https://codereview.chromium.org/2211473003/diff/120001/net/tools/testserver/r...
File net/tools/testserver/run_testserver.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/net/tools/testserver/r...
net/tools/testserver/run_testserver.cc:125: base::RunLoop().Run();
Should the |message_loop| variable be removed?

[fdoray, 2016-08-06 01:26:14]

agl@: PTAnL

https://codereview.chromium.org/2211473003/diff/120001/net/tools/get_server_t...
File net/tools/get_server_time/get_server_time.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/net/tools/get_server_t...
net/tools/get_server_time/get_server_time.cc:256: base::RunLoop().Run();
On 2016/08/06 00:44:00, agl wrote:
> The |main_loop| variable is still created and passed to
> TrivialURLRequestContextGetter, but now never run?

MessageLoop(ForIO|ForUI) sets a pointer to itself in TLS when it is
instantiated. This pointer can be retrieved by calling MessageLoop::current().
RunLoop().Run() runs the MessageLoop returned by MessageLoop::current().
Therefore, |main_loop| is still important.

Why do we ask people to use RunLoop / why are we deprecating MessageLoop::Run?
- Our long-term goal is to deprecate MessageLoop::Quit/QuitWhenIdle. With these
methods, it isn't clear which call to Run() is exited. It is clearer with
RunLoop. E.g.:

void FunctionA() {
  ...
  if (...) {
     MessageLoop::current()->Quit();
     // What? Did I just killed the thread? Or a nested run of the MessageLoop?
  }
}

void FunctionB() {
  ThreadTaskRunnerHandle::Get()->PostTask(
    FROM_HERE, Bind(&FunctionA));
  MessageLoop::current()->Run();
}

vs.

void FunctionA(RunLoop* run_loop) {
  ...
  if (...) {
     run_loop->Quit();
  }
}

void FunctionB() {
  RunLoop run_loop;
  ThreadTaskRunnerHandle::Get()->PostTask(
    FROM_HERE, Bind(&FunctionA, Unretained(&run_loop)));
  run_loop.Run();
}

- Many browser threads that are currently backed by a MessageLoop are about to
be replaced with base/task_scheduler. RunLoop().Run() will work with
base/task_scheduler (will run nested tasks), but MessageLoop::current()->Run()
won't.

Please note that changes to this code don't affect its behavior. See
https://cs.chromium.org/chromium/src/base/message_loop/message_loop.cc?sq=pac...

https://codereview.chromium.org/2211473003/diff/120001/net/tools/net_watcher/...
File net/tools/net_watcher/net_watcher.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/net/tools/net_watcher/...
net/tools/net_watcher/net_watcher.cc:218: base::RunLoop().Run();
On 2016/08/06 00:44:00, agl wrote:
> This one seems a little suspect, although I'm not sure. The |network_loop|
> variable is still created and passed to a function, but never run?

see previous comment.

Note that the implementation of MessageLoop::Run() is equivalent to the code
that I inlined here. MessageLoop::Run() will soon go away.
https://cs.chromium.org/chromium/src/base/message_loop/message_loop.cc?sq=pac...

https://codereview.chromium.org/2211473003/diff/120001/net/tools/testserver/r...
File net/tools/testserver/run_testserver.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/net/tools/testserver/r...
net/tools/testserver/run_testserver.cc:125: base::RunLoop().Run();
On 2016/08/06 00:44:00, agl wrote:
> Should the |message_loop| variable be removed?

No. It needs to exist. Throughout its lifetime, a pointer to it can be obtained
through MessageLoop::current(). RunLoop needs that pointer.

[David Trainor- moved to gerrit, 2016-08-06 04:35:39]

blimp lgtm

[fdoray, 2016-08-08 13:04:45]

jam@: I added you as a reviewer for content/ since jochen@ is OOO

ash derat@chromium.org [Done]
base thestig@chromium.org [Done]
blimp dtrainor@chromium.org [Done]
chrome thestig@chromium.org [Done]
components caitkp@chromium.org
content jam@chromium.org
dbus hashimoto@chromium.org
device reillyg@chromium.org [Done]
extensions reillyg@chromium.org [Done]
gpu sievers@chromium.org
ipc jam@chromium.org [Done]
jingle sergeyu@chromium.org [Done]
mash ben@chromium.org
media chcunningham@chromium.org
mojo ben@chromium.org
net agl@chromium.org
ppapi bbudge@chromium.org [Done]
remoting garykac@chromium.org [Done]
sandbox jschuh@chromium.org
services jam@chromium.org [Done]
tools/android digit@chromium.org
ui sadrul@chromium.org

[Cait (Slow), 2016-08-08 15:34:58]

https://codereview.chromium.org/2211473003/diff/120001/components/sync/tools/...
File components/sync/tools/testserver/run_sync_testserver.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/components/sync/tools/...
components/sync/tools/testserver/run_sync_testserver.cc:75:
base::MessageLoopForIO message_loop;
is this still needed?

https://codereview.chromium.org/2211473003/diff/120001/components/sync_sessio...
File components/sync_sessions/favicon_cache_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/components/sync_sessio...
components/sync_sessions/favicon_cache_unittest.cc:299: base::MessageLoopForUI
message_loop_;
is this still needed?

[fdoray, 2016-08-08 15:39:53]

caitkp@: PTAnL

https://codereview.chromium.org/2211473003/diff/120001/components/sync/tools/...
File components/sync/tools/testserver/run_sync_testserver.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/components/sync/tools/...
components/sync/tools/testserver/run_sync_testserver.cc:75:
base::MessageLoopForIO message_loop;
On 2016/08/08 15:34:57, Cait (slow) wrote:
> is this still needed?

Yes. RunLoop::Run() has to be called in the scope of a MessageLoop. It gets a
pointer to that MessageLoop via MessageLoop::current() and runs it.

https://codereview.chromium.org/2211473003/diff/120001/components/sync_sessio...
File components/sync_sessions/favicon_cache_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/components/sync_sessio...
components/sync_sessions/favicon_cache_unittest.cc:299: base::MessageLoopForUI
message_loop_;
On 2016/08/08 15:34:57, Cait (slow) wrote:
> is this still needed?

ditto

[chcunningham, 2016-08-08 16:51:01]

media LGTM

[Cait (Slow), 2016-08-08 19:24:34]

On 2016/08/08 15:39:53, fdoray wrote:
> caitkp@: PTAnL
> 
>
https://codereview.chromium.org/2211473003/diff/120001/components/sync/tools/...
> File components/sync/tools/testserver/run_sync_testserver.cc (right):
> 
>
https://codereview.chromium.org/2211473003/diff/120001/components/sync/tools/...
> components/sync/tools/testserver/run_sync_testserver.cc:75:
> base::MessageLoopForIO message_loop;
> On 2016/08/08 15:34:57, Cait (slow) wrote:
> > is this still needed?
> 
> Yes. RunLoop::Run() has to be called in the scope of a MessageLoop. It gets a
> pointer to that MessageLoop via MessageLoop::current() and runs it.
> 
>
https://codereview.chromium.org/2211473003/diff/120001/components/sync_sessio...
> File components/sync_sessions/favicon_cache_unittest.cc (right):
> 
>
https://codereview.chromium.org/2211473003/diff/120001/components/sync_sessio...
> components/sync_sessions/favicon_cache_unittest.cc:299: base::MessageLoopForUI
> message_loop_;
> On 2016/08/08 15:34:57, Cait (slow) wrote:
> > is this still needed?
> 
> ditto

Makes sense. 
My only worry is that others will make the same mistake I did, delete the
"unused" lines and be confused by the ensuing test failures. Might be a good
idea to make sure that the messages around errors of  this type are as explicit
as possible.

[Cait (Slow), 2016-08-08 19:25:07]

components lgtm

[fdoray, 2016-08-08 19:48:09]

caitkp@: Ack

ash derat@chromium.org [Done]
base thestig@chromium.org [Done]
blimp dtrainor@chromium.org [Done]
chrome thestig@chromium.org [Done]
components caitkp@chromium.org [Done]
content jam@chromium.org
dbus hashimoto@chromium.org
device reillyg@chromium.org [Done]
extensions reillyg@chromium.org [Done]
gpu sievers@chromium.org
ipc jam@chromium.org [Done]
jingle sergeyu@chromium.org [Done]
mash ben@chromium.org
media chcunningham@chromium.org [Done]
mojo ben@chromium.org
net agl@chromium.org
ppapi bbudge@chromium.org [Done]
remoting garykac@chromium.org [Done]
sandbox jschuh@chromium.org
services jam@chromium.org [Done]
tools/android digit@chromium.org
ui sadrul@chromium.org

[sadrul, 2016-08-08 20:42:43]

I think when you replace the usage of MessageLoop::QuitWhenIdle with
RunLoop::QuitWhenIdle, you will need to touch a number of the same places, and
update the RunLoop().Run() callsites as well. My suggestion would be to replace
both at the same time. That way, the same code wouldn't need to go be changed
again. I am not going to block this CL on that, but please do consider it.

lgtm

https://codereview.chromium.org/2211473003/diff/120001/ui/app_list/views/apps...
File ui/app_list/views/apps_grid_view_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/ui/app_list/views/apps...
ui/app_list/views/apps_grid_view_unittest.cc:57: base::RunLoop().Run();
I think this should remain ui_loop_->Run(), or ui_loop_->QuitWhenIdle() below
should also be converted to use RunLoop::QuitWhenIdle

https://codereview.chromium.org/2211473003/diff/120001/ui/events/platform/pla...
File ui/events/platform/platform_event_source_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/ui/events/platform/pla...
ui/events/platform/platform_event_source_unittest.cc:511:
message_loop_.QuitWhenIdle();
Use RunLoop here too?

https://codereview.chromium.org/2211473003/diff/120001/ui/keyboard/keyboard_c...
File ui/keyboard/keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller_unittest.cc:158:
base::MessageLoop::current()->QuitWhenIdle();
Runloop?

[hashimoto, 2016-08-15 03:59:15]

dbus lgtm

[fdoray, 2016-08-23 15:20:31]

On 2016/08/08 20:42:43, sadrul wrote:
> I think when you replace the usage of MessageLoop::QuitWhenIdle with
> RunLoop::QuitWhenIdle, you will need to touch a number of the same places, and
> update the RunLoop().Run() callsites as well. My suggestion would be to
replace
> both at the same time. That way, the same code wouldn't need to go be changed
> again. I am not going to block this CL on that, but please do consider it.
> 
> lgtm

Unfortunately, migrating calls to Quit/QuitWhenIdle cannot be automated as
easily as migrating calls to Run/RunUntilIdle. Migrating calls to
MessageLoop::Run/RunUntilIdle will allow us to delete these methods. Once these
methods are deleted, developers will be forced to learn about RunLoop and
hopefully will stop introducing new calls to MessageLoop::QuitNow/QuitWhenIdle.

[fdoray, 2016-08-23 15:30:27]

https://codereview.chromium.org/2211473003/diff/120001/ui/app_list/views/apps...
File ui/app_list/views/apps_grid_view_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/ui/app_list/views/apps...
ui/app_list/views/apps_grid_view_unittest.cc:57: base::RunLoop().Run();
On 2016/08/08 20:42:42, sadrul wrote:
> I think this should remain ui_loop_->Run(), or ui_loop_->QuitWhenIdle() below
> should also be converted to use RunLoop::QuitWhenIdle

Done.

https://codereview.chromium.org/2211473003/diff/120001/ui/events/platform/pla...
File ui/events/platform/platform_event_source_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/ui/events/platform/pla...
ui/events/platform/platform_event_source_unittest.cc:511:
message_loop_.QuitWhenIdle();
On 2016/08/08 20:42:42, sadrul wrote:
> Use RunLoop here too?

Done.

https://codereview.chromium.org/2211473003/diff/120001/ui/keyboard/keyboard_c...
File ui/keyboard/keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/2211473003/diff/120001/ui/keyboard/keyboard_c...
ui/keyboard/keyboard_controller_unittest.cc:158:
base::MessageLoop::current()->QuitWhenIdle();
On 2016/08/08 20:42:42, sadrul wrote:
> Runloop?

Done.

[fdoray, 2016-08-23 15:40:10]

I will create a separate CL for directories that have not been LGTMed yet.

[fdoray, 2016-08-23 15:40:52]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

With this CL, there is no remaining call to these methods on Windows
and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[fdoray, 2016-08-23 15:41:17]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-08-23 15:41:19]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
bbudge@chromium.org, jam@chromium.org, reillyg@chromium.org,
thestig@chromium.org, sergeyu@chromium.org, sadrul@chromium.org,
chcunningham@chromium.org, hashimoto@chromium.org, derat@chromium.org,
dtrainor@chromium.org, caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/2211473003/#ps160001
(title: "reset non-LGTMed directories (gpu, mojo, net, sandbox, tools)")

[commit-bot: I haz the power, 2016-08-23 15:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 16:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 16:13:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-08-23 18:27:19]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-08-23 18:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
sergeyu@chromium.org, gab@chromium.org, jam@chromium.org, reillyg@chromium.org,
sadrul@chromium.org, chcunningham@chromium.org, thestig@chromium.org,
hashimoto@chromium.org, derat@chromium.org, dtrainor@chromium.org,
caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/2211473003/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-23 18:28:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 19:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:19:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2016-08-23 19:24:11]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:24:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agl, 2016-08-23 19:42:05]

net/ LGTM

[commit-bot: I haz the power, 2016-08-23 20:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 20:08:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-08-24 15:22:15]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-08-24 15:22:16]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
sergeyu@chromium.org, agl@chromium.org, gab@chromium.org, jam@chromium.org,
reillyg@chromium.org, sadrul@chromium.org, chcunningham@chromium.org,
thestig@chromium.org, hashimoto@chromium.org, derat@chromium.org,
dtrainor@chromium.org, caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/2211473003/#ps220001
(title: "add net")

[commit-bot: I haz the power, 2016-08-24 15:22:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:33:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fdoray, 2016-08-24 15:45:06]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-08-24 15:45:07]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
sergeyu@chromium.org, agl@chromium.org, gab@chromium.org, jam@chromium.org,
reillyg@chromium.org, sadrul@chromium.org, chcunningham@chromium.org,
thestig@chromium.org, hashimoto@chromium.org, derat@chromium.org,
dtrainor@chromium.org, caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/2211473003/#ps240001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-24 15:45:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:20:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:20:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2016-08-25 14:01:07]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-08-25 14:01:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 15:37:00]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-08-25 15:37:05]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-08-25 15:38:37]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove calls to deprecated MessageLoop methods on Windows and Linux.

This Cl removes most calls to these methods on Windows and Linux:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Also note that calls to thread->message_loop()->task_runner() have
been replaced with thread->task_runner() (|thread| is a base::Thread).

This CL was generated by running the clang-tidy checks available here
https://crbug.com/616447#c153 on Windows and Mac and by applying a few
manual fixes (e.g. to remove a call made from a macro in
audio_low_latency_input_win_unittest.cc).

BUG=616447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941
Cr-Commit-Position: refs/heads/master@{#414442}
==========

[commit-bot: I haz the power, 2016-08-25 15:38:41]

Patchset 13 (id:??) landed as
https://crrev.com/6ef45cf47455fb44e8fa0ab5d1ba545c91429941
Cr-Commit-Position: refs/heads/master@{#414442}