Remove calls to deprecated MessageLoop methods on Windows and Linux.

components/sync_sessions/favicon_cache_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync_sessions/favicon_cache.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "components/sync/api/attachments/attachment_id.h"
 #include "components/sync/api/sync_change_processor_wrapper_for_test.h"
 #include "components/sync/api/sync_error_factory_mock.h"
 #include "components/sync/api/time.h"
 #include "components/sync/core/attachments/attachment_service_proxy_for_test.h"
 #include "components/sync/protocol/favicon_image_specifics.pb.h"
@@ skipping 265 matching lines @@
   void OnCustomFaviconDataAvailable(const TestFaviconData& test_data);
 
   // Helper method to run the message loop after invoking
   // OnReceivedSyncFavicon, which posts an internal task.
   void TriggerSyncFaviconReceived(const GURL& page_url,
                                   const GURL& icon_url,
                                   const std::string& icon_bytes,
                                   int64_t last_visit_time_ms);
 
  private:
   base::MessageLoopForUI message_loop_;

[Cait (Slow), 2016/08/08 15:34:57]

is this still needed?

[fdoray, 2016/08/08 15:39:52]

ditto

   FaviconCache cache_;
 
   // Our dummy ChangeProcessor used to inspect changes pushed to Sync.
   std::unique_ptr<TestChangeProcessor> sync_processor_;
   std::unique_ptr<syncer::SyncChangeProcessorWrapperForTest>
       sync_processor_wrapper_;
 };
 
 SyncFaviconCacheTest::SyncFaviconCacheTest()
     : cache_(nullptr, nullptr, kMaxSyncFavicons),
@@ skipping 140 matching lines @@
 
 void SyncFaviconCacheTest::TriggerSyncFaviconReceived(
     const GURL& page_url,
     const GURL& icon_url,
     const std::string& icon_bytes,
     int64_t last_visit_time_ms) {
   cache()->OnReceivedSyncFavicon(page_url,
                                  icon_url,
                                  icon_bytes,
                                  last_visit_time_ms);
-  message_loop_.RunUntilIdle();
+  base::RunLoop().RunUntilIdle();
 }
 
 // A freshly constructed cache should be empty.
 TEST_F(SyncFaviconCacheTest, Empty) {
   EXPECT_EQ(0U, GetFaviconCount());
 }
 
 TEST_F(SyncFaviconCacheTest, ReceiveSyncFavicon) {
   std::string page_url = "http://www.google.com";
   std::string fav_url = "http://www.google.com/favicon.ico";
@@ skipping 1458 matching lines @@
   EXPECT_EQ(changes[4].change_type(), syncer::SyncChange::ACTION_ADD);
   EXPECT_EQ(changes[4].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
   EXPECT_EQ(kMaxSyncFavicons, GetFaviconId(changes[4]));
   // Expire tracking for favicon[0].
   EXPECT_EQ(changes[5].change_type(), syncer::SyncChange::ACTION_DELETE);
   EXPECT_EQ(changes[5].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
   EXPECT_EQ(0, GetFaviconId(changes[5]));
 }
 
 }  // namespace browser_sync