Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2212223003: Remove calls to deprecated MessageLoop methods in suggestions_service_unittest.cc (Closed)

Created:
4 years, 4 months ago by fdoray
Modified:
4 years, 4 months ago
Reviewers:
Mathieu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in suggestions_service_unittest.cc This CL replaces calls to MessageLoop::RunUntilIdle with RunLoop().RunUntilIdle() in suggestions_service_unittest.cc. Note that there is no reason to call RunUntilIdle() multiple times in a row. After a call returns, the MessageLoop is idle. It stays idle until a task is posted or a timer expires. There is no reason to call RunUntilIdle() before that. BUG=616447 Committed: https://crrev.com/428e75e2645afccd3683e2c0700765f3dc0a3b83 Cr-Commit-Position: refs/heads/master@{#410339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M components/suggestions/suggestions_service_unittest.cc View 8 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
fdoray
PTAL
4 years, 4 months ago (2016-08-06 01:08:55 UTC) #10
fdoray
-jam@ mathp@: PTAL
4 years, 4 months ago (2016-08-06 01:09:38 UTC) #12
Mathieu
Thanks for the cleanup! lgtm
4 years, 4 months ago (2016-08-06 19:23:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212223003/1
4 years, 4 months ago (2016-08-08 13:00:04 UTC) #15
commit-bot: I haz the power
Failed to apply the patch.
4 years, 4 months ago (2016-08-08 13:33:00 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 13:33:46 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/428e75e2645afccd3683e2c0700765f3dc0a3b83
Cr-Commit-Position: refs/heads/master@{#410339}

Powered by Google App Engine
This is Rietveld 408576698