chrome/browser/password_manager/native_backend_libsecret_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc ('k') | chrome/browser/password_manager/password_store_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

index 84480e940a64b372a81333fa4d5c3168b49ef0ff..50ee221e6009b6050c7aa9d46fdf21fdb72f4c73 100644

--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

@@ -7,6 +7,7 @@

#include <stdint.h>

#include "base/location.h"

+#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/stl_util.h"

#include "base/strings/string_number_conversions.h"

@@ -338,12 +339,12 @@ class NativeBackendLibsecretTest : public testing::Test {

void TearDown() override {

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

ASSERT_TRUE(global_mock_libsecret_items);

global_mock_libsecret_items = nullptr;

}

- void RunUIThread() { base::MessageLoop::current()->Run(); }

+ void RunUIThread() { base::RunLoop().Run(); }

void CheckUint32Attribute(const MockSecretItem* item,

const std::string& attribute,