Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2219053002: Remove calls to deprecated MessageLoop methods in site_instance_impl_unittest.cc (Closed)

Created:
4 years, 4 months ago by fdoray
Modified:
4 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, jam, ajwong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in site_instance_impl_unittest.cc This CL replaces calls to MessageLoop::RunUntilIdle with RunLoop().RunUntilIdle() in site_instance_impl_unittest.cc. Note that there is no reason to call RunUntilIdle() multiple times in a row. After a call returns, the MessageLoop is idle. It stays idle until a task is posted or a timer expires. There is no reason to call RunUntilIdle() before that. BUG=616447 Committed: https://crrev.com/e46618d151ea43f2a7cc135f25cea6a173f67a58 Cr-Commit-Position: refs/heads/master@{#410447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M content/browser/site_instance_impl_unittest.cc View 14 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
fdoray
jam@: PTAL
4 years, 4 months ago (2016-08-06 01:09:56 UTC) #10
jam
lgtm
4 years, 4 months ago (2016-08-08 19:49:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219053002/1
4 years, 4 months ago (2016-08-08 19:49:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:42:18 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:44:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e46618d151ea43f2a7cc135f25cea6a173f67a58
Cr-Commit-Position: refs/heads/master@{#410447}

Powered by Google App Engine
This is Rietveld 408576698