Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: base/message_loop/message_pump_glib_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_loop_unittest.cc ('k') | base/message_loop/message_pump_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_glib_unittest.cc
diff --git a/base/message_loop/message_pump_glib_unittest.cc b/base/message_loop/message_pump_glib_unittest.cc
index 3ee068b9a295c46339428400f2abdbf18f273939..9259debaa70e426326ff772826d8f94f71a103d2 100644
--- a/base/message_loop/message_pump_glib_unittest.cc
+++ b/base/message_loop/message_pump_glib_unittest.cc
@@ -17,6 +17,7 @@
#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
+#include "base/single_thread_task_runner.h"
#include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -195,7 +196,7 @@ TEST_F(MessagePumpGLibTest, TestQuit) {
injector()->Reset();
// Quit from an event
injector()->AddEvent(0, MessageLoop::QuitWhenIdleClosure());
- loop()->Run();
+ RunLoop().Run();
EXPECT_EQ(1, injector()->processed_events());
}
@@ -215,7 +216,7 @@ TEST_F(MessagePumpGLibTest, TestEventTaskInterleave) {
injector()->AddEventAsTask(0, posted_task);
injector()->AddEventAsTask(0, Bind(&DoNothing));
injector()->AddEvent(0, MessageLoop::QuitWhenIdleClosure());
- loop()->Run();
+ RunLoop().Run();
EXPECT_EQ(4, injector()->processed_events());
injector()->Reset();
@@ -226,7 +227,7 @@ TEST_F(MessagePumpGLibTest, TestEventTaskInterleave) {
injector()->AddEventAsTask(0, posted_task);
injector()->AddEventAsTask(10, Bind(&DoNothing));
injector()->AddEvent(0, MessageLoop::QuitWhenIdleClosure());
- loop()->Run();
+ RunLoop().Run();
EXPECT_EQ(4, injector()->processed_events());
}
@@ -235,15 +236,15 @@ TEST_F(MessagePumpGLibTest, TestWorkWhileWaitingForEvents) {
// Tests that we process tasks while waiting for new events.
// The event queue is empty at first.
for (int i = 0; i < 10; ++i) {
- loop()->PostTask(FROM_HERE, Bind(&IncrementInt, &task_count));
+ loop()->task_runner()->PostTask(FROM_HERE,
+ Bind(&IncrementInt, &task_count));
}
// After all the previous tasks have executed, enqueue an event that will
// quit.
- loop()->PostTask(
- FROM_HERE,
- Bind(&EventInjector::AddEvent, Unretained(injector()), 0,
- MessageLoop::QuitWhenIdleClosure()));
- loop()->Run();
+ loop()->task_runner()->PostTask(
+ FROM_HERE, Bind(&EventInjector::AddEvent, Unretained(injector()), 0,
+ MessageLoop::QuitWhenIdleClosure()));
+ RunLoop().Run();
ASSERT_EQ(10, task_count);
EXPECT_EQ(1, injector()->processed_events());
@@ -251,21 +252,19 @@ TEST_F(MessagePumpGLibTest, TestWorkWhileWaitingForEvents) {
injector()->Reset();
task_count = 0;
for (int i = 0; i < 10; ++i) {
- loop()->PostDelayedTask(
- FROM_HERE,
- Bind(&IncrementInt, &task_count),
- TimeDelta::FromMilliseconds(10*i));
+ loop()->task_runner()->PostDelayedTask(FROM_HERE,
+ Bind(&IncrementInt, &task_count),
+ TimeDelta::FromMilliseconds(10 * i));
}
// After all the previous tasks have executed, enqueue an event that will
// quit.
// This relies on the fact that delayed tasks are executed in delay order.
// That is verified in message_loop_unittest.cc.
- loop()->PostDelayedTask(
- FROM_HERE,
- Bind(&EventInjector::AddEvent, Unretained(injector()), 10,
- MessageLoop::QuitWhenIdleClosure()),
+ loop()->task_runner()->PostDelayedTask(
+ FROM_HERE, Bind(&EventInjector::AddEvent, Unretained(injector()), 10,
+ MessageLoop::QuitWhenIdleClosure()),
TimeDelta::FromMilliseconds(150));
- loop()->Run();
+ RunLoop().Run();
ASSERT_EQ(10, task_count);
EXPECT_EQ(1, injector()->processed_events());
}
@@ -287,7 +286,7 @@ TEST_F(MessagePumpGLibTest, TestEventsWhileWaitingForWork) {
// And then quit (relies on the condition tested by TestEventTaskInterleave).
injector()->AddEvent(10, MessageLoop::QuitWhenIdleClosure());
- loop()->Run();
+ RunLoop().Run();
EXPECT_EQ(12, injector()->processed_events());
}
@@ -363,12 +362,12 @@ TEST_F(MessagePumpGLibTest, TestConcurrentEventPostedTask) {
0, Bind(&ConcurrentHelper::FromEvent, helper.get()));
// Similarly post 2 tasks.
- loop()->PostTask(
+ loop()->task_runner()->PostTask(
FROM_HERE, Bind(&ConcurrentHelper::FromTask, helper.get()));
- loop()->PostTask(
+ loop()->task_runner()->PostTask(
FROM_HERE, Bind(&ConcurrentHelper::FromTask, helper.get()));
- loop()->Run();
+ RunLoop().Run();
EXPECT_EQ(0, helper->event_count());
EXPECT_EQ(0, helper->task_count());
}
@@ -396,10 +395,9 @@ void AddEventsAndDrainGLib(EventInjector* injector) {
TEST_F(MessagePumpGLibTest, TestDrainingGLib) {
// Tests that draining events using GLib works.
- loop()->PostTask(
- FROM_HERE,
- Bind(&AddEventsAndDrainGLib, Unretained(injector())));
- loop()->Run();
+ loop()->task_runner()->PostTask(
+ FROM_HERE, Bind(&AddEventsAndDrainGLib, Unretained(injector())));
+ RunLoop().Run();
EXPECT_EQ(3, injector()->processed_events());
}
@@ -512,10 +510,9 @@ TEST_F(MessagePumpGLibTest, TestGLibLoop) {
// loop is not run by MessageLoop::Run() but by a straight GLib loop.
// Note that in this case we don't make strong guarantees about niceness
// between events and posted tasks.
- loop()->PostTask(
- FROM_HERE,
- Bind(&TestGLibLoopInternal, Unretained(injector())));
- loop()->Run();
+ loop()->task_runner()->PostTask(
+ FROM_HERE, Bind(&TestGLibLoopInternal, Unretained(injector())));
+ RunLoop().Run();
}
TEST_F(MessagePumpGLibTest, TestGtkLoop) {
@@ -523,10 +520,9 @@ TEST_F(MessagePumpGLibTest, TestGtkLoop) {
// loop is not run by MessageLoop::Run() but by a straight Gtk loop.
// Note that in this case we don't make strong guarantees about niceness
// between events and posted tasks.
- loop()->PostTask(
- FROM_HERE,
- Bind(&TestGtkLoopInternal, Unretained(injector())));
- loop()->Run();
+ loop()->task_runner()->PostTask(
+ FROM_HERE, Bind(&TestGtkLoopInternal, Unretained(injector())));
+ RunLoop().Run();
}
} // namespace base
« no previous file with comments | « base/message_loop/message_loop_unittest.cc ('k') | base/message_loop/message_pump_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698