Remove calls to deprecated MessageLoop methods on Windows and Linux.

ash/test/shelf_view_test_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/test/shelf_view_test_api.h"
 
 #include "ash/common/shelf/overflow_button.h"
 #include "ash/common/shelf/shelf_button.h"
 #include "ash/common/shelf/shelf_constants.h"
 #include "ash/common/shelf/shelf_model.h"
 #include "ash/shelf/shelf_view.h"
 #include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
 #include "ui/views/animation/bounds_animator.h"
 #include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/view_model.h"
 
 namespace {
 
 // A class used to wait for animations.
 class TestAPIAnimationObserver : public views::BoundsAnimatorObserver {
  public:
   TestAPIAnimationObserver() {}
   ~TestAPIAnimationObserver() override {}
 
   // views::BoundsAnimatorObserver overrides:
   void OnBoundsAnimatorProgressed(views::BoundsAnimator* animator) override {}
   void OnBoundsAnimatorDone(views::BoundsAnimator* animator) override {
     base::MessageLoop::current()->QuitWhenIdle();

[Daniel Erat, 2016/08/05 18:55:14]

should this be calling QuitWhenIdle() on the RunLoop instead? (doesn't need to
happen now if it's still safe to do this.)

[fdoray, 2016/08/05 23:41:36]

This will be done in another refactoring phase. Our goal is to remove
MessageLoop::Run() as soon as possible so that people have no choice to use
RunLoop (and hopefully will call QuitWhenIdle on that RunLoop). Once this is
done, we will migrate calls to MessageLoop::QuitWhenIdle (which is trickier to
do).

   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestAPIAnimationObserver);
 };
 
 }  // namespace
 
 namespace ash {
 namespace test {
@@ skipping 47 matching lines @@
 void ShelfViewTestAPI::RunMessageLoopUntilAnimationsDone() {
   if (!shelf_view_->bounds_animator_->IsAnimating())
     return;
 
   std::unique_ptr<TestAPIAnimationObserver> observer(
       new TestAPIAnimationObserver());
   shelf_view_->bounds_animator_->AddObserver(observer.get());
 
   // This nested loop will quit when TestAPIAnimationObserver's
   // OnBoundsAnimatorDone is called.
-  base::MessageLoop::current()->Run();
+  base::RunLoop().Run();
 
   shelf_view_->bounds_animator_->RemoveObserver(observer.get());
 }
 
 void ShelfViewTestAPI::CloseMenu() {
   if (!shelf_view_->launcher_menu_runner_)
     return;
 
   shelf_view_->launcher_menu_runner_->Cancel();
 }
@@ skipping 49 matching lines @@
   return shelf_view_->dragged_off_from_overflow_to_shelf_;
 }
 
 ShelfButtonPressedMetricTracker*
 ShelfViewTestAPI::shelf_button_pressed_metric_tracker() {
   return &(shelf_view_->shelf_button_pressed_metric_tracker_);
 }
 
 }  // namespace test
 }  // namespace ash