Remove calls to deprecated MessageLoop methods on Windows and Linux.

content/browser/site_instance_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/site_instance_impl.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 120 matching lines @@
 
   void set_privileged_process_id(int process_id) {
     browser_client_.set_privileged_process_id(process_id);
   }
 
   void DrainMessageLoops() {
     // We don't just do this in TearDown() because we create TestBrowserContext
     // objects in each test, which will be destructed before
     // TearDown() is called.
     base::RunLoop().RunUntilIdle();
-    message_loop_.RunUntilIdle();
+    base::RunLoop().RunUntilIdle();

[fdoray, 2016/08/04 18:48:21]

Why are there 2 calls?

[gab, 2016/08/05 01:09:57]

Probably because the developer thought he was flushing two different things in
old code. Worth a separate CL with its owners IMO to make sure they're aware it
didn't do what they thought it did.

[fdoray, 2016/08/05 16:10:36]

Done. https://codereview.chromium.org/2219053002/

   }
 
   SiteInstanceTestBrowserClient* browser_client() { return &browser_client_; }
 
  private:
   base::MessageLoopForUI message_loop_;
   TestBrowserThread ui_thread_;
   TestBrowserThread file_user_blocking_thread_;
   TestBrowserThread io_thread_;
 
@@ skipping 689 matching lines @@
   EXPECT_EQ(1, browser_client()->GetAndClearSiteInstanceDeleteCount());
   EXPECT_EQ(0, browser_client()->GetAndClearBrowsingInstanceDeleteCount());
 
   // Free the subframe instance, which should free the browsing instance.
   subframe_instance = nullptr;
   EXPECT_EQ(1, browser_client()->GetAndClearSiteInstanceDeleteCount());
   EXPECT_EQ(1, browser_client()->GetAndClearBrowsingInstanceDeleteCount());
 }
 
 }  // namespace content