Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
caseq
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed InspectorTest.invokeFunctionInPageAsync BUG=632875 R=caseq@chromium.org Committed: https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134 Cr-Commit-Position: refs/heads/master@{#411813}

Patch Set 1 #

Total comments: 72

Patch Set 2 : addressed comments #

Patch Set 3 : fixed tests :( #

Total comments: 24

Patch Set 4 : addressed comments #

Patch Set 5 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -562 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/tracing-test.js View 1 1 chunk +1 line, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-fetch-logging.html View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-fetch-logging-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +0 lines, -50 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resources/extension-main.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js View 1 2 3 4 3 chunks +22 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-script-parse.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-xhr-event.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-xhr-response-type-blob-event.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/tracing/websocket/timeline-websocket-event.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-dispatchEvent.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-layout.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html View 1 1 chunk +10 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-timer.html View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/css-rule-hover-highlights-selectors.html View 1 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-resources.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing-session-id.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/anonymous-image-object.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/decode-resize.html View 1 2 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/frame-model-instrumentation.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/scroll-invalidations.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-gc-event.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html View 1 2 3 1 chunk +12 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations-expected.txt View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-animation-frame.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-animation-frame-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes-expected.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations-expected.txt View 9 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-receive-response-event.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html View 1 1 chunk +5 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html View 1 1 chunk +5 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/layer-tree.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint.html View 1 2 3 1 chunk +6 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.html View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations-expected.txt View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations.html View 1 2 3 1 chunk +9 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-expected.txt View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html View 1 2 chunks +13 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node-expected.txt View 1 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html View 1 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/update-layer-tree.html View 1 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/parse-author-style-sheet.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.html View 1 2 3 1 chunk +32 lines, -50 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-all-invalidator-types-expected.txt View 1 11 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidations.html View 1 1 chunk +24 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidations-expected.txt View 1 10 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html View 1 1 chunk +34 lines, -43 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations-expected.txt View 1 22 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-expected.txt View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/worker-events.html View 1 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/worker-js-frames.html View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/idle-callback.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/idle-callback-expected.txt View 1 2 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 35 (22 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-04 00:41:02 UTC) #1
kozy
Andrey, please take a look at tracing tests.
4 years, 4 months ago (2016-08-04 00:46:07 UTC) #3
kozy
ping?
4 years, 4 months ago (2016-08-05 02:18:53 UTC) #4
dgozman
Harness looks good. @caseq: please take a look at tracing bits.
4 years, 4 months ago (2016-08-05 02:26:14 UTC) #7
caseq
https://codereview.chromium.org/2208963002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js (right): https://codereview.chromium.org/2208963002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js#newcode48 third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js:48: return fetch(url, requestInitializer).catch((e) => e); e => e https://codereview.chromium.org/2208963002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js#newcode120 ...
4 years, 4 months ago (2016-08-05 17:56:43 UTC) #8
kozy
All done! Please take another look! https://codereview.chromium.org/2208963002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js (right): https://codereview.chromium.org/2208963002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js#newcode48 third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js:48: return fetch(url, requestInitializer).catch((e) ...
4 years, 4 months ago (2016-08-10 01:21:15 UTC) #10
caseq
https://codereview.chromium.org/2208963002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js (right): https://codereview.chromium.org/2208963002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js#newcode470 third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js:470: .then(() => waitForFrame()); merge into above? https://codereview.chromium.org/2208963002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js#newcode479 third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js:479: if ...
4 years, 4 months ago (2016-08-10 22:44:55 UTC) #18
kozy
Please take another look! https://codereview.chromium.org/2208963002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js (right): https://codereview.chromium.org/2208963002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js#newcode470 third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js:470: .then(() => waitForFrame()); On 2016/08/10 ...
4 years, 4 months ago (2016-08-11 01:34:17 UTC) #19
kozy
friendly ping!
4 years, 4 months ago (2016-08-12 18:50:15 UTC) #28
caseq
lgtm and thanks a lot for simplifying the tests!
4 years, 4 months ago (2016-08-12 21:43:40 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208963002/80001
4 years, 4 months ago (2016-08-12 21:46:39 UTC) #31
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-12 23:24:57 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 23:30:28 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134
Cr-Commit-Position: refs/heads/master@{#411813}

Powered by Google App Engine
This is Rietveld 408576698