Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html
index 34954c03ed5c12e5d7cb0044c71c9d20cc72c5e2..ae17be65734a326f2035298c268e26c2a80e7d53 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html
@@ -4,30 +4,18 @@
<script src="../../../http/tests/inspector/timeline-test.js"></script>
<script>
-function performActions(callback)
+function performActions()
{
- function onImageLoad()
- {
- window._imageLoaded = true;
- if (window._scriptEvaluated)
- callback();
- }
-
- function scriptEvaluated()
- {
- window._scriptEvaluated = true;
- if (window._imageLoaded)
- callback();
- }
-
var image = new Image();
- image.onload = onImageLoad;
+ var imagePromise = new Promise((fulfill) => image.onload = fulfill);
image.src = "../resources/anImage.png";
+
+ var scriptPromise = new Promise((fulfill) => window.timelineNetworkResourceEvaluated = fulfill);
var script = document.createElement("script");
script.src = "timeline-network-resource.js";
document.body.appendChild(script);
- window.timelineNetworkResourceEvaluated = scriptEvaluated;
+ return Promise.all([imagePromise, scriptPromise]);
}
function test()

Powered by Google App Engine
This is Rietveld 408576698