Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html
index 7bc3e4de193c0cd1602898d71205a7125d736437..408bebd0dc12b4d1b7207940a56bdced0228f01c 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html
@@ -4,10 +4,10 @@
<script src="../../../http/tests/inspector/timeline-test.js"></script>
<script>
-function performActions(callback)
+function performActions()
{
- window.callWhenDone = callback;
- var content = "" +
+ var promise = new Promise((fulfill) => window.callWhenDone = fulfill);
+ var content = "" +
"var fn2 = function() {" +
" console.markTimeline(\"Script evaluated\");" +
" window.callWhenDone();" +
@@ -23,6 +23,7 @@ function performActions(callback)
scriptElement.appendChild(contentNode);
document.body.appendChild(scriptElement);
document.body.removeChild(scriptElement);
+ return promise;
}
function test()

Powered by Google App Engine
This is Rietveld 408576698