Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html b/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
index 61d0a958beacfc6f46d1466313c976fde00d60cb..8aaf9aa2c785e06985a7d30e00c2c3243d28f437 100644
--- a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
+++ b/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
@@ -4,33 +4,26 @@
<script type="text/javascript" src="../../http/tests/inspector-protocol/tracing-test.js"></script>
<script>
-function performActions(callback)
+function performActions()
{
- var rafId1 = requestAnimationFrame(function()
- {
- evaluateInFrontend("InspectorTest.testFunctionRequestAnimationFrame(" + rafId1 + ", " + rafId2 + ")");
- callback();
- });
-
- var rafId2 = requestAnimationFrame(function() { });
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
+ var rafId2;
+ var rafId1 = requestAnimationFrame(() => callback({ rafId1: rafId1, rafId2: rafId2 }));
+ rafId2 = requestAnimationFrame(function() { });
cancelAnimationFrame(rafId2);
+ return promise;
}
function test()
{
InspectorTest.invokeAsyncWithTracing("performActions", finish);
- var firedRaf;
- var canceledRaf;
- InspectorTest.testFunctionRequestAnimationFrame = function(rafId1, rafId2)
+ function finish(devtoolsEvents, data)
{
- firedRaf = rafId1;
- canceledRaf = rafId2;
- InspectorTest.log("SUCCESS: testFunctionRequestAnimationFrame");
- }
+ var firedRaf = data.rafId1;
+ var canceledRaf = data.rafId2;
- function finish(devtoolsEvents)
- {
function hasRafId(id, e) { return e.args.data.id === id}
var raf1 = InspectorTest.findEvent("RequestAnimationFrame", "I", hasRafId.bind(this, firedRaf));

Powered by Google App Engine
This is Rietveld 408576698