third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html - Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html

index fc3cbd3a0e8771ae6cde90272608ac6041daface..637c75e4f89307f273bed33230ea32cb7f551d32 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html

@@ -285,7 +285,7 @@ InspectorTest.evaluateInPage = function(string, callback)

InspectorTest.evaluateInPageAsync = function(expression)

{

- return InspectorTest.sendCommandPromise("Runtime.evaluate", { "expression": expression, awaitPromise: true }).then((message) => message.result.result.value);

+ return InspectorTest.sendCommandPromise("Runtime.evaluate", { "expression": expression, awaitPromise: true, returnByValue: true }).then((message) => message.result.result.value);

}

InspectorTest.completeTestIfError = function(messageObject)

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-protocol/tracing-test.js » ('j') | no next file with comments »