Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
index 5b98db768890b10d11ff5dd085eed162f480eb83..92ba023e7b705f5c95fd557bb0d611c8dade85b5 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
@@ -15,9 +15,9 @@ function test()
InspectorTest.runTestSuite([
function testTimerInstall(next)
{
- function setTimeoutFunction(callback)
+ function setTimeoutFunction()
{
- setTimeout(callback, 0);
+ return new Promise((fulfill) => setTimeout(fulfill, 0));
}
var source = setTimeoutFunction.toString();
@@ -35,7 +35,7 @@ function test()
WebInspector.TimelineUIUtils._generateCauses(event, InspectorTest.timelineModel().targetByEvent(event), null, contentHelper);
var causes = contentHelper.element.deepTextContent();
InspectorTest.check(causes, "Should generate causes");
- checkStringContains(causes, "Timer InstalledsetTimeoutFunction @ setTimeoutFunction.js:");
+ checkStringContains(causes, "Timer InstalledPromise @ setTimeoutFunction.js:");
next();
}
},
@@ -44,7 +44,7 @@ function test()
{
function requestAnimationFrameFunction(callback)
{
- requestAnimationFrame(callback);
+ return new Promise((fulfill) => requestAnimationFrame(fulfill));
}
var source = requestAnimationFrameFunction.toString();
@@ -62,7 +62,7 @@ function test()
WebInspector.TimelineUIUtils._generateCauses(event, InspectorTest.timelineModel().targetByEvent(event), null, contentHelper);
var causes = contentHelper.element.deepTextContent();
InspectorTest.check(causes, "Should generate causes");
- checkStringContains(causes, "Animation Frame RequestedrequestAnimationFrameFunction @ requestAnimationFrameFunction.js:");
+ checkStringContains(causes, "Animation Frame RequestedPromise @ requestAnimationFrameFunction.js:");
next();
}
},

Powered by Google App Engine
This is Rietveld 408576698