third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html - Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/resources/extension-main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html

index 4851bfc18d77d97df9fe9d8a560e11569215f9f5..7bd39fe2295488aa450cf53d40322c0dafbd2d7e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html

@@ -4,11 +4,14 @@

-function receiveEvent(callback)

+function receiveEvent()

{

+ var callback;

+ var promise = new Promise((fulfill) => callback = fulfill);

var es = new EventSource("resources/event-stream.asis");

es.onmessage = onMessage;

es.onerror = onError;

+ return promise;

function onMessage(data)

{

output("got event: " + event.data);

@@ -24,7 +27,7 @@ function receiveEvent(callback)

function test()

{

InspectorTest.recordNetwork();

- InspectorTest.invokePageFunctionAsync("receiveEvent", step2);

+ InspectorTest.callFunctionInPageAsync("receiveEvent").then(step2);

function step2()

{