Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html
index f059bb51586b79a8e7975d191654e2d3d6297a45..d133e073b5eb9a48aba4bf2c448cc89f572f35d6 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html
@@ -3,8 +3,10 @@
<script src="../../../http/tests/inspector/inspector-test.js"></script>
<script src="../../../http/tests/inspector/timeline-test.js"></script>
<script>
-function display(callback)
+function display()
{
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
if (window.testRunner)
testRunner.setCanOpenWindows(true);
var popup = window.open("data:text/html,<b>Hello, world</b>");
@@ -12,6 +14,7 @@ function display(callback)
{
requestAnimationFrame(testRunner.capturePixelsAsyncThen.bind(testRunner, callback));
}
+ return promise;
}
function test()
@@ -21,7 +24,7 @@ function test()
function pageReloaded()
{
- InspectorTest.invokePageFunctionAsync("display", displayDone);
+ InspectorTest.callFunctionInPageAsync("display").then(displayDone);
}
function displayDone()

Powered by Google App Engine
This is Rietveld 408576698