Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2206963002: Plumb the frame name through the popup blocker (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer, Torne, alokp
CC:
alokp+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, halliwell+watch_chromium.org, jam, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb the frame name through the popup blocker BUG=599941 R=bauerb@chromium.org TBR=torne@chromium.org,alokp@chromium.org TEST=browser_tests:PopupBlockerBrowserTest.CorrectFrameName Committed: https://crrev.com/67b271b2cbac7d0af1c0fb25c273b04d948a0e89 Cr-Commit-Position: refs/heads/master@{#409503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_window_params.h View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_window_params.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator_params.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/test/data/popup_blocker/check-framename.html View 1 chunk +5 lines, -3 lines 0 comments Download
A + chrome/test/data/popup_blocker/popup-framename.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-03 09:36:38 UTC) #1
jochen (gone - plz use gerrit)
Bernhard, ptal TBR torne/alokp for updating API changes in android_webview and chromecast respectively
4 years, 4 months ago (2016-08-03 09:40:33 UTC) #4
Torne
android_webview lgtm
4 years, 4 months ago (2016-08-03 12:02:25 UTC) #7
Bernhard Bauer
rubberstamp lgtm
4 years, 4 months ago (2016-08-03 12:31:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206963002/1
4 years, 4 months ago (2016-08-03 12:48:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 13:50:37 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 13:52:05 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/67b271b2cbac7d0af1c0fb25c273b04d948a0e89
Cr-Commit-Position: refs/heads/master@{#409503}

Powered by Google App Engine
This is Rietveld 408576698