Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6153)

Unified Diff: chrome/browser/ui/blocked_content/blocked_window_params.cc

Issue 2206963002: Plumb the frame name through the popup blocker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/blocked_content/blocked_window_params.cc
diff --git a/chrome/browser/ui/blocked_content/blocked_window_params.cc b/chrome/browser/ui/blocked_content/blocked_window_params.cc
index 819b075a43a9be5ccd3f68ef8395d2167b85204c..2266367d8ad9f62d426121ca9ac25b10855036a5 100644
--- a/chrome/browser/ui/blocked_content/blocked_window_params.cc
+++ b/chrome/browser/ui/blocked_content/blocked_window_params.cc
@@ -15,6 +15,7 @@
BlockedWindowParams::BlockedWindowParams(
const GURL& target_url,
const content::Referrer& referrer,
+ const std::string& frame_name,
WindowOpenDisposition disposition,
const blink::WebWindowFeatures& features,
bool user_gesture,
@@ -23,6 +24,7 @@ BlockedWindowParams::BlockedWindowParams(
int opener_render_frame_id)
: target_url_(target_url),
referrer_(referrer),
+ frame_name_(frame_name),
disposition_(disposition),
features_(features),
user_gesture_(user_gesture),
@@ -34,6 +36,8 @@ BlockedWindowParams::BlockedWindowParams(
BlockedWindowParams::BlockedWindowParams(const BlockedWindowParams& other) =
default;
+BlockedWindowParams::~BlockedWindowParams() = default;
+
chrome::NavigateParams BlockedWindowParams::CreateNavigateParams(
content::WebContents* web_contents) const {
GURL popup_url(target_url_);
@@ -43,6 +47,7 @@ chrome::NavigateParams BlockedWindowParams::CreateNavigateParams(
popup_url,
ui::PAGE_TRANSITION_LINK);
nav_params.referrer = referrer_;
+ nav_params.frame_name = frame_name_;
nav_params.source_contents = web_contents;
nav_params.is_renderer_initiated = true;
nav_params.tabstrip_add_types = TabStripModel::ADD_ACTIVE;

Powered by Google App Engine
This is Rietveld 408576698