Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 2206963002: Plumb the frame name through the popup blocker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator.cc
diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc
index 1d41d50fdee0766b342ab6b726936d00231d4cf0..ab0fcfbcc32476fc5b8b204dfee8089eda8b94dc 100644
--- a/chrome/browser/ui/browser_navigator.cc
+++ b/chrome/browser/ui/browser_navigator.cc
@@ -255,6 +255,7 @@ void LoadURLInContents(WebContents* target_contents,
NavigationController::LoadURLParams load_url_params(url);
load_url_params.source_site_instance = params->source_site_instance;
load_url_params.referrer = params->referrer;
+ load_url_params.frame_name = params->frame_name;
load_url_params.frame_tree_node_id = params->frame_tree_node_id;
load_url_params.redirect_chain = params->redirect_chain;
load_url_params.transition_type = params->transition;
@@ -338,6 +339,7 @@ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params,
params.source_site_instance
? params.source_site_instance
: tab_util::GetSiteInstanceForNewTab(params.browser->profile(), url));
+ create_params.main_frame_name = params.frame_name;
if (params.source_contents) {
create_params.initial_size =
params.source_contents->GetContainerBounds().size();
« no previous file with comments | « chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc ('k') | chrome/browser/ui/browser_navigator_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698