chrome/browser/chrome_content_browser_client.cc - Issue 2206963002: Plumb the frame name through the popup blocker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2206963002: Plumb the frame name through the popup blocker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 81b0a1d1e7159518550ef50caf8d9b5883e4a1d5..c00b48914a3ccf4fe64d34460caac1e3c434b4a2 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -2160,6 +2160,7 @@ bool ChromeContentBrowserClient::CanCreateWindow(

WindowContainerType container_type,

const GURL& target_url,

const content::Referrer& referrer,

+ const std::string& frame_name,

WindowOpenDisposition disposition,

const WebWindowFeatures& features,

bool user_gesture,

@@ -2237,6 +2238,7 @@ bool ChromeContentBrowserClient::CanCreateWindow(

ProfileIOData::FromResourceContext(context)->GetHostContentSettingsMap();

BlockedWindowParams blocked_params(target_url,

referrer,

+ frame_name,

disposition,

features,

user_gesture,