chrome/test/data/popup_blocker/popup-framename.html - Issue 2206963002: Plumb the frame name through the popup blocker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/popup_blocker/popup-framename.html

Issue 2206963002: Plumb the frame name through the popup blocker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/popup_blocker/popup-framename.html

diff --git a/chrome/test/data/popup_blocker/popup-opener.html b/chrome/test/data/popup_blocker/popup-framename.html

similarity index 51%

copy from chrome/test/data/popup_blocker/popup-opener.html

copy to chrome/test/data/popup_blocker/popup-framename.html

index db9d0fa7a919ad196ca5e71a1a6efef055a13830..1830717f040a40350b4e0073e6aa16719c1b74e0 100644

--- a/chrome/test/data/popup_blocker/popup-opener.html

+++ b/chrome/test/data/popup_blocker/popup-framename.html

@@ -1,11 +1,11 @@

<html>

<head>

<title>

- Check that the window.opener is not set when opening a blocked popup

+ Check that the frame name is correctly set when opening a blocked popup

</title>

function test() {

- window.open("check-opener.html");

+ window.open("check-framename.html", "fancyname");

}

</script>

</head>